Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upServo seems to be allowing expandos/defined properties to be set in cases that incorrectly shadow indexed/named setters #25448
Labels
Projects
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
After applying #25446, html/dom/elements/global-attributes/dataset-binding.window.html and dom/collections/HTMLCollection-supported-property-indices.html pass some subtests they previously failed, but also still have failures.
html/dom/elements/global-attributes/dataset-binding.window.html calls defineProperty(DOMStringMap.prototype, ...) and expects the "set" method of the new property to never be invoked.
dom/collections/HTMLCollection-supported-property-indices.html sets and deletes some indexed properties on the HTMLCollection returned by document.getElementsByTagName, and it expects exceptions in some cases when doing so (in some cases, only in "use strict").
These seem like things that IDL codegen is supposed to catch before reaching class-specific manual code. Indexed and named setters go through different codepaths, but they're parallel enough that looking at the two issues side-by-side might help.