Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTMLFormElement past names map "age" needs to be monotonic, and probably shouldn't be a literal time #25455

Open
pshaughn opened this issue Jan 7, 2020 · 0 comments

Comments

@pshaughn
Copy link
Member

@pshaughn pshaughn commented Jan 7, 2020

https://html.spec.whatwg.org/multipage/forms.html#past-names-map needs to sort things by various fields that include the length of time they've been in the map; our current implementation takes this very literally, calling now() to get timestamps.

now() is the wrong type of timestamp for this (https://doc.rust-lang.org/std/time/struct.SystemTime.html "this time measurement is not monotonic"), and beyond that I am pretty sure something like a serial number would suffice here, as we are only comparing entries within a single map at a time and not actually using the times for anything but a sort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.