Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMessageEvent and ExtendableMessageEvent have some issues #25464
Closed
Comments
This was referenced Jan 8, 2020
bors-servo
added a commit
that referenced
this issue
Jan 9, 2020
Use dom and new_inherited in (extendable)messageevent <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #25464 (GitHub issue number if applicable) <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The implementations of
MessageEventandExtendableMessageEventhave some issues.Firstly, they store
Vec<DomRoot<T>>in on their DOM object, they should be usingVec<Dom<T>>:servo/components/script/dom/messageevent.rs
Line 63 in a77318b
servo/components/script/dom/extendablemessageevent.rs
Line 34 in a77318b
Secondly, they're constructing the type directly in
new()instead of using anew_inheritedservo/components/script/dom/extendablemessageevent.rs
Lines 48 to 54 in a77318b
servo/components/script/dom/messageevent.rs
Lines 86 to 93 in a77318b
We should fix these issues.
cc @gterzian