Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In AsyncWGPUListener, reject promise with OperationError #25492

Closed
gterzian opened this issue Jan 11, 2020 · 2 comments
Closed

In AsyncWGPUListener, reject promise with OperationError #25492

gterzian opened this issue Jan 11, 2020 · 2 comments
Labels
A-content/script

Comments

@gterzian
Copy link
Member

@gterzian gterzian commented Jan 11, 2020

servo/components/script/dom/gpu.rs

Line 59 in 3740754

Err(error) => promise.reject_error(Error::Type(format!(

It looks to me like the spec always wants an Error::OperationError to be used, see for example https://gpuweb.github.io/gpuweb/#requestadapter

@zakorgy
@zakorgy zakorgy mentioned this issue Jan 13, 2020
Merged
2 of 3 tasks complete
@atouchet
Copy link
Contributor

@atouchet atouchet commented Jan 13, 2020

Did #25030 fix this?
@jdm
Copy link
Member

@jdm jdm commented Jan 13, 2020

Yes.
@jdm jdm closed this Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/script
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@jdm @gterzian @atouchet
You can’t perform that action at this time.