Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Root element background extents are wrong in layout_2020 #25559

Closed
mrobinson opened this issue Jan 20, 2020 · 1 comment
Closed

Root element background extents are wrong in layout_2020 #25559

mrobinson opened this issue Jan 20, 2020 · 1 comment
Labels
A-layout/2020 C-has-manual-testcase

Comments

@mrobinson
Copy link
Member

@mrobinson mrobinson commented Jan 20, 2020

It looks like root element background extents aren't including page margins and don't cover the page viewport.

This shows a white page:

<body style="background: green;"></body>

This shows a green page with 8 pixel white borders on the top and right:

<body style="background: green;">
    <div style="height: 10000px;"></div>
</body>

This shows a completely green page. This is what I would expect for all test cases:

<body style="background: green;">
    <div style="height: 10000px;"></div>
</body>
mrobinson added a commit to mrobinson/servo that referenced this issue Jan 20, 2020
@mrobinson
Add a workaround to root_scroll.html for servo#25559
adc7dee 
This allows us to test initial root scrolling support in Layout 2020
and can hopefully be removed very soon.
mrobinson added a commit to mrobinson/servo that referenced this issue Jan 20, 2020
@mrobinson
Add a workaround to root_scroll.html for servo#25559
72ce074 
This allows us to test initial root scrolling support in Layout 2020
and can hopefully be removed very soon.
mrobinson added a commit to mrobinson/servo that referenced this issue Jan 20, 2020
@mrobinson
Add a workaround to root_scroll.html for servo#25559
ec038d6 
This allows us to test initial root scrolling support in Layout 2020
and can hopefully be removed very soon.
@SimonSapin
Copy link
Member

@SimonSapin SimonSapin commented Jan 20, 2020

The relevant spec is:

This affects the border painting area and painting order (position in the display list) of background layers for the root element (or in some cases HTML <body> element).

The painting area (mistakenly called clipping_area in current master) needs to be theoretically infinite, although in practice only the part that intersects with the scrollable overflow rectangle for the document can be painted.
mrobinson added a commit to mrobinson/servo that referenced this issue Jan 21, 2020
@mrobinson
Add a workaround to root_scroll.html for servo#25559
24ed328 
This allows us to test initial root scrolling support in Layout 2020
and can hopefully be removed very soon.
mrobinson added a commit to mrobinson/servo that referenced this issue Jan 21, 2020
@mrobinson
Add a workaround to root_scroll.html for servo#25559
8a94029 
This allows us to test initial root scrolling support in Layout 2020
and can hopefully be removed very soon.
mrobinson added a commit to mrobinson/servo that referenced this issue Jan 21, 2020
@mrobinson
Add a workaround to root_scroll.html for servo#25559
e4a55d7 
This allows us to test initial root scrolling support in Layout 2020
and can hopefully be removed very soon.
@SimonSapin SimonSapin mentioned this issue Mar 20, 2020
Closed
mrobinson added a commit to mrobinson/servo that referenced this issue Apr 6, 2020
@mrobinson
layout_2020: Properly handle HTML element background
50e85ab 
The CSS Backgrounds and Borders specification describes the
circumstances under which the HTML element's used style for backgrounds
is determined by the BODY element. This change properly implements that
behavior, fixing a variety of tests that expect the background specified
on the BODY cover the entire page.

Fixes: servo#25559
@mrobinson mrobinson mentioned this issue Apr 6, 2020
Closed
4 of 5 tasks complete
mrobinson added a commit to mrobinson/servo that referenced this issue Apr 6, 2020
@mrobinson
layout_2020: Properly handle HTML element background
5e31278 
The CSS Backgrounds and Borders specification describes the
circumstances under which the HTML element's used style for backgrounds
is determined by the BODY element. This change properly implements that
behavior, fixing a variety of tests that expect the background specified
on the BODY cover the entire page.

Fixes: servo#25559
mrobinson added a commit to mrobinson/servo that referenced this issue Apr 6, 2020
@mrobinson
layout_2020: Properly handle HTML element background
2cea25d 
The CSS Backgrounds and Borders specification describes the
circumstances under which the HTML element's used style for backgrounds
is determined by the BODY element. This change properly implements that
behavior, fixing a variety of tests that expect the background specified
on the BODY cover the entire page.

Fixes: servo#25559
mrobinson added a commit to mrobinson/servo that referenced this issue Apr 7, 2020
@mrobinson
layout_2020: Properly handle HTML element background
71790ab 
The CSS Backgrounds and Borders specification describes the
circumstances under which the HTML element's used style for backgrounds
is determined by the BODY element. This change properly implements that
behavior, fixing a variety of tests that expect the background specified
on the BODY cover the entire page.

Fixes: servo#25559
mrobinson added a commit to mrobinson/servo that referenced this issue Apr 7, 2020
@mrobinson
layout_2020: Properly handle HTML element background
9b0ebbe 
The CSS Backgrounds and Borders specification describes the
circumstances under which the HTML element's used style for backgrounds
is determined by the BODY element. This change properly implements that
behavior, fixing a variety of tests that expect the background specified
on the BODY cover the entire page.

Fixes: servo#25559
SimonSapin added a commit that referenced this issue May 4, 2020
@SimonSapin
Correctly paint the CSS canvas’ background
8cbc635 
https://drafts.csswg.org/css-backgrounds/#special-backgrounds

Fixes #25559
Closes #26121, as it is an alternative.
@SimonSapin SimonSapin mentioned this issue May 4, 2020
Merged
bors-servo added a commit that referenced this issue May 4, 2020
@bors-servo
Auto merge of #26414 - servo:canvas-background2, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
5454e9b 
Correctly paint the CSS canvas’ background

https://drafts.csswg.org/css-backgrounds/#special-backgrounds

Fixes #25559
Closes #26121, as it is an alternative.
SimonSapin added a commit that referenced this issue May 7, 2020
@SimonSapin
Correctly paint the CSS canvas’ background
a8088bd 
https://drafts.csswg.org/css-backgrounds/#special-backgrounds

Fixes #25559
Closes #26121, as it is an alternative.
SimonSapin added a commit that referenced this issue May 7, 2020
@SimonSapin
Correctly paint the CSS canvas’ background
ce21ffb 
https://drafts.csswg.org/css-backgrounds/#special-backgrounds

Fixes #25559
Closes #26121, as it is an alternative.
bors-servo added a commit that referenced this issue May 7, 2020
@bors-servo
Auto merge of #26414 - servo:canvas-background2, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
ce9c20f 
Correctly paint the CSS canvas’ background

https://drafts.csswg.org/css-backgrounds/#special-backgrounds

Fixes #25559
Closes #26121, as it is an alternative.
Fixes #26444.
SimonSapin added a commit that referenced this issue May 7, 2020
@SimonSapin
Correctly paint the CSS canvas’ background
90d0287 
https://drafts.csswg.org/css-backgrounds/#special-backgrounds

Fixes #25559
Closes #26121, as it is an alternative.
SimonSapin added a commit that referenced this issue May 13, 2020
@SimonSapin
Correctly paint the CSS canvas’ background
1b95ed4 
https://drafts.csswg.org/css-backgrounds/#special-backgrounds

Fixes #25559
Closes #26121, as it is an alternative.
SimonSapin added a commit that referenced this issue May 14, 2020
@SimonSapin
Correctly paint the CSS canvas’ background
345770f 
https://drafts.csswg.org/css-backgrounds/#special-backgrounds

Fixes #25559
Closes #26121, as it is an alternative.
bors-servo added a commit that referenced this issue May 15, 2020
@bors-servo
Auto merge of #26414 - servo:canvas-background2, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
13011ee 
Correctly paint the CSS canvas’ background

https://drafts.csswg.org/css-backgrounds/#special-backgrounds

Fixes #25559
Closes #26121, as it is an alternative.
Fixes #26444.
bors-servo added a commit that referenced this issue May 15, 2020
@bors-servo
Auto merge of #26414 - servo:canvas-background2, r=mrobinson
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
7d7e987 
Correctly paint the CSS canvas’ background

https://drafts.csswg.org/css-backgrounds/#special-backgrounds

Fixes #25559
Closes #26121, as it is an alternative.
Fixes #26444.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-layout/2020 C-has-manual-testcase
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Correctly paint the CSS canvas’ background
layout_2020: Properly handle HTML element background
2 participants
@mrobinson @SimonSapin
You can’t perform that action at this time.