Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upOn Python 3, Mach doesn't set executable permission when extracting zips, breaking `bootstrap-android` #25618
Comments
|
As the second and third answer in that Stack Overflow issue, this is because this library uses different method in it in Python 3.6 and later. |
bors-servo
added a commit
that referenced
this issue
Feb 10, 2020
fix zip extraction for python 3 Fix #25618 Confirmed that this worked in Python 3.6 and Python 2.7. Ref: https://stackoverflow.com/questions/805066/call-a-parent-classs-method-from-child-class --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #25618 (GitHub issue number if applicable) <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
bors-servo
added a commit
that referenced
this issue
Feb 10, 2020
fix zip extraction for python 3 Fix #25618 Confirmed that this worked in Python 3.6 and Python 2.7. Ref: https://stackoverflow.com/questions/805066/call-a-parent-classs-method-from-child-class --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #25618 (GitHub issue number if applicable) <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When running
python3 ./mach bootstrap-android --buildusing Python 3, I get this error:It looks like
servo/python/servo/util.py
Line 174 in 7596a0f