Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upignore_malloc_size_of in NodeIterator and HTMLCollection points at closed issue #6870 #25682
Labels
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Since #6870 was resolved I tried taking out the ignore_malloc_size_of lines here, but we still seem to need them. I might not understand what's really happening here, but it looks like the NodeIterator one involves an
Rc<NodeFilterBinding::NodeFilter>, which seems like the kind of thing 6870 was supposed to fix. The HTMLCollection one involves aBox<dyn CollectionFilter + 'static>which seems like it probably has to stay ignore_malloc_size_of since the CollectionFilter trait could be hiding anything as far as the compiler knows. The sensible thing to do in the latter case might just be to clean up the comment and leave the ignore on, but the former could point at something to fix in the macros.