Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text is not wrapped around div with replaced content in layout_2020 #25709

Closed
mrobinson opened this issue Feb 7, 2020 · 2 comments
Closed

Text is not wrapped around div with replaced content in layout_2020 #25709

mrobinson opened this issue Feb 7, 2020 · 2 comments

Comments

@mrobinson
Copy link
Member

@mrobinson mrobinson commented Feb 7, 2020

In the following test case the text appears on top of the div, but it should really be positioned under it.

<div><img style="background: pink; width: 100px; height: 100px;"></div>
<p>this should be under</p>

Output:
Screenshot from 2020-02-07 16-32-07

@mrobinson mrobinson changed the title Text is not wrapped around div with replaced content Text is not wrapped around div with replaced content in layout_2020 Feb 7, 2020
@mrobinson
Copy link
Member Author

@mrobinson mrobinson commented Feb 7, 2020

@SimonSapin
Copy link
Member

@SimonSapin SimonSapin commented Feb 7, 2020

This <img> element has the initial display: inline, so it ends being part of a line box. It looks like the height of that line box incorrectly ends up being zero. Since the element doesn’t have an src attribute I’m not sure what kind of box it ends up generating. Either way, the bug likely a missing something.max_block_size_of_fragments_so_far.max_assign(something) somewhere in components/layout_2020/flow/inline.rs

@ferjm ferjm self-assigned this Feb 25, 2020
@ferjm ferjm mentioned this issue Feb 26, 2020
3 of 3 tasks complete
bors-servo added a commit that referenced this issue Feb 26, 2020
Properly position atomic inline level boxes

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #25709
bors-servo added a commit that referenced this issue Feb 26, 2020
Properly position atomic inline level boxes

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #25709
bors-servo added a commit that referenced this issue Feb 26, 2020
Properly position atomic inline level boxes

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #25709
bors-servo added a commit that referenced this issue Feb 26, 2020
Properly position atomic inline level boxes

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #25709
bors-servo added a commit that referenced this issue Feb 26, 2020
Properly position atomic inline level boxes

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #25709
bors-servo added a commit that referenced this issue Feb 27, 2020
Properly position atomic inline level boxes

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #25709
bors-servo added a commit that referenced this issue Feb 27, 2020
Properly position atomic inline level boxes

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #25709
bors-servo added a commit that referenced this issue Feb 27, 2020
Properly position atomic inline level boxes

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #25709
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants
You can’t perform that action at this time.