Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMutating the tabindex content attribute isn't changing focusability #25713
Labels
Projects
Comments
bors-servo
added a commit
that referenced
this issue
Feb 13, 2020
sketching ElementInternals Form-associated elements are now working. Remaining test failures in custom-elements/form-associated/ are: * whatwg/html#4658 hasn't made it into the standard yet, and ElementInternals-accessibility is all about that functionality. * ElementInternals-setFormValue hits many race conditions with our iframe order of operations. Isolating just the "submit this form with these custom elements, look at the query" part, the payload of each test actually does pass! Running the tests as written, we end up with different tests overwriting each other's elements and getting very confused. One problem is the about:blank double-load-event thing, but fixing that doesn't fix everything. * ElementInternals-validation doesn't work because we don't have form validation in general; I've commented the relevant stubs. * ElementInternals-form-disabled-callback fails on #25713.
|
This was fixed by #26902. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm not sure whether there's a specific test for adding tabindex, but html/interaction/focus/processing-model/focus-fixup-rule-one-no-dialogs.html case "Removing the tabindex attribute from a div" tests removing it and fails.
Servo only checks for tabindex in HTMLElement::update_sequentially_focusable_status, which is only called from HTMLElement::bind_to_tree, so any changes to the attribute on an already-inserted node will have no effect on focusability (unless the node happens to also get inserted into a tree again).