Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UWP smoketest to CI #25718

Open
jdm opened this issue Feb 10, 2020 · 7 comments · May be fixed by #25745
Open

Add UWP smoketest to CI #25718

jdm opened this issue Feb 10, 2020 · 7 comments · May be fixed by #25745
Labels

Comments

@jdm
Copy link
Member

@jdm jdm commented Feb 10, 2020

It would be nice to avoid problems like #25683 in the future. @ferjm You mentioned you were able to launch the UWP app from the command line in the past; could you explain how you did that so we can see if we can replicate it in CI?

@jdm jdm added the A-testing label Feb 10, 2020
@ferjm
Copy link
Member

@ferjm ferjm commented Feb 10, 2020

#24534 introduced support for launching the UWP from cli with the "Servo" command (from any path). However, IIRC it required launching the app once from VS so the command gets registered.

@ferjm
Copy link
Member

@ferjm ferjm commented Feb 10, 2020

Oh, according to https://blogs.windows.com/windowsdeveloper/2017/07/05/command-line-activation-universal-windows-apps/#UaF9ZyFfdF9kYhdY.97 the command alias is also registered when the user installs the app.

@paulrouget
Copy link
Contributor

@paulrouget paulrouget commented Feb 12, 2020

So far I managed to open Servo, but I haven’t found a way yet to know of the launch was successful or not:

  • use #25661 + a correct certificate (the PR doesn’t appear to have the right hash for ServoApp_TemporaryKey.pfx
  • install the certificate: certutil.exe -addstore "Root" .\ServoApp_1.0.0.0_x64_Debug.cer
  • install the package: Add-AppxPackage -Path .\ServoApp_1.0.0.0_x64_Debug.appxbundle
  • run it: explorer.exe "shell:appsFolder\MozillaFoundation.FirefoxReality_XXX!App"

where XXX is the result of (Get-AppxPackage -Name MozillaFoundation.FirefoxReality).ToString().

@paulrouget
Copy link
Contributor

@paulrouget paulrouget commented Feb 12, 2020

There’s a much easier way to open Servo:

  • start fxr://http://example.com

And to see if it succeeded, it looks easier to start a local http server and wait for Servo to request that page:

  • start fxr://http://localhost:45678
@paulrouget
Copy link
Contributor

@paulrouget paulrouget commented Feb 12, 2020

To close: taskkill /f /im servoapp.exe.

@paulrouget
Copy link
Contributor

@paulrouget paulrouget commented Feb 12, 2020

To summarize, we could have a python script that:

  1. install the cert with certutil.exe. Could this be done once for all on the CI?
  2. install the app via Add-AppxPackage
  3. start httpd server
  4. launch servo: start fxr://http://localhost:45678
  5. wait until HTTP request or timeout
  6. taskkill app
  7. uninstall app: Get-AppxPackage MozillaFoundation.FirefoxReality | Remove-AppxPackage
@paulrouget
Copy link
Contributor

@paulrouget paulrouget commented Feb 12, 2020

Servo doesn’t appear to like loading localhost: #25741

bors-servo added a commit that referenced this issue Feb 14, 2020
make sure UWP app can run

Fix #25718

This includes #25661 with some minor tweaks (certificate file reference was missing, and its id was wrong) and a python script.

Still need to hook that to our CI.
bors-servo added a commit that referenced this issue Feb 28, 2020
make sure UWP app can run

Fix #25718

This includes #25661 with some minor tweaks (certificate file reference was missing, and its id was wrong) and a python script.

Still need to hook that to our CI.
bors-servo added a commit that referenced this issue Feb 28, 2020
make sure UWP app can run

Fix #25718

This includes #25661 with some minor tweaks (certificate file reference was missing, and its id was wrong) and a python script.

Still need to hook that to our CI.
bors-servo added a commit that referenced this issue Feb 28, 2020
make sure UWP app can run

Fix #25718

This includes #25661 with some minor tweaks (certificate file reference was missing, and its id was wrong) and a python script.

Still need to hook that to our CI.
bors-servo added a commit that referenced this issue Mar 2, 2020
make sure UWP app can run

Fix #25718

This includes #25661 with some minor tweaks (certificate file reference was missing, and its id was wrong) and a python script.

Still need to hook that to our CI.
bors-servo added a commit that referenced this issue Mar 2, 2020
make sure UWP app can run

Fix #25718

This includes #25661 with some minor tweaks (certificate file reference was missing, and its id was wrong) and a python script.

Still need to hook that to our CI.
bors-servo added a commit that referenced this issue Mar 2, 2020
make sure UWP app can run

Fix #25718

This includes #25661 with some minor tweaks (certificate file reference was missing, and its id was wrong) and a python script.

Still need to hook that to our CI.
bors-servo added a commit that referenced this issue Mar 2, 2020
make sure UWP app can run

Fix #25718

This includes #25661 with some minor tweaks (certificate file reference was missing, and its id was wrong) and a python script.

Still need to hook that to our CI.
bors-servo added a commit that referenced this issue Mar 2, 2020
make sure UWP app can run

Fix #25718

This includes #25661 with some minor tweaks (certificate file reference was missing, and its id was wrong) and a python script.

Still need to hook that to our CI.
bors-servo added a commit that referenced this issue Mar 2, 2020
make sure UWP app can run

Fix #25718

This includes #25661 with some minor tweaks (certificate file reference was missing, and its id was wrong) and a python script.

Still need to hook that to our CI.
bors-servo added a commit that referenced this issue Mar 2, 2020
make sure UWP app can run

Fix #25718

This includes #25661 with some minor tweaks (certificate file reference was missing, and its id was wrong) and a python script.

Still need to hook that to our CI.
bors-servo added a commit that referenced this issue Mar 3, 2020
make sure UWP app can run

Fix #25718

This includes #25661 with some minor tweaks (certificate file reference was missing, and its id was wrong) and a python script.

Still need to hook that to our CI.
bors-servo added a commit that referenced this issue Mar 3, 2020
make sure UWP app can run

Fix #25718

This includes #25661 with some minor tweaks (certificate file reference was missing, and its id was wrong) and a python script.

Still need to hook that to our CI.
bors-servo added a commit that referenced this issue Mar 3, 2020
make sure UWP app can run

Fix #25718

This includes #25661 with some minor tweaks (certificate file reference was missing, and its id was wrong) and a python script.

Still need to hook that to our CI.
bors-servo added a commit that referenced this issue Mar 3, 2020
make sure UWP app can run

Fix #25718

This includes #25661 with some minor tweaks (certificate file reference was missing, and its id was wrong) and a python script.

Still need to hook that to our CI.
bors-servo added a commit that referenced this issue Mar 3, 2020
make sure UWP app can run

Fix #25718

This includes #25661 with some minor tweaks (certificate file reference was missing, and its id was wrong) and a python script.

Still need to hook that to our CI.
bors-servo added a commit that referenced this issue Mar 3, 2020
make sure UWP app can run

Fix #25718

This includes #25661 with some minor tweaks (certificate file reference was missing, and its id was wrong) and a python script.

Still need to hook that to our CI.
bors-servo added a commit that referenced this issue Mar 4, 2020
make sure UWP app can run

Fix #25718

This includes #25661 with some minor tweaks (certificate file reference was missing, and its id was wrong) and a python script.

Still need to hook that to our CI.
bors-servo added a commit that referenced this issue Mar 14, 2020
make sure UWP app can run

Fix #25718

This includes #25661 with some minor tweaks (certificate file reference was missing, and its id was wrong) and a python script.

Still need to hook that to our CI.
bors-servo added a commit that referenced this issue Mar 17, 2020
make sure UWP app can run

Fix #25718

This includes #25661 with some minor tweaks (certificate file reference was missing, and its id was wrong) and a python script.

Still need to hook that to our CI.
bors-servo added a commit that referenced this issue Mar 17, 2020
make sure UWP app can run

Fix #25718

This includes #25661 with some minor tweaks (certificate file reference was missing, and its id was wrong) and a python script.

Still need to hook that to our CI.
bors-servo added a commit that referenced this issue Mar 17, 2020
make sure UWP app can run

Fix #25718

This includes #25661 with some minor tweaks (certificate file reference was missing, and its id was wrong) and a python script.

Still need to hook that to our CI.
bors-servo added a commit that referenced this issue Mar 17, 2020
make sure UWP app can run

Fix #25718

This includes #25661 with some minor tweaks (certificate file reference was missing, and its id was wrong) and a python script.

Still need to hook that to our CI.
bors-servo added a commit that referenced this issue Mar 17, 2020
make sure UWP app can run

Fix #25718

This includes #25661 with some minor tweaks (certificate file reference was missing, and its id was wrong) and a python script.

Still need to hook that to our CI.
bors-servo added a commit that referenced this issue Mar 17, 2020
make sure UWP app can run

Fix #25718

This includes #25661 with some minor tweaks (certificate file reference was missing, and its id was wrong) and a python script.

Still need to hook that to our CI.
bors-servo added a commit that referenced this issue Mar 17, 2020
make sure UWP app can run

Fix #25718

This includes #25661 with some minor tweaks (certificate file reference was missing, and its id was wrong) and a python script.

Still need to hook that to our CI.
bors-servo added a commit that referenced this issue Mar 17, 2020
make sure UWP app can run

Fix #25718

This includes #25661 with some minor tweaks (certificate file reference was missing, and its id was wrong) and a python script.

Still need to hook that to our CI.
bors-servo added a commit that referenced this issue Mar 17, 2020
make sure UWP app can run

Fix #25718

This includes #25661 with some minor tweaks (certificate file reference was missing, and its id was wrong) and a python script.

Still need to hook that to our CI.
bors-servo added a commit that referenced this issue Mar 18, 2020
make sure UWP app can run

Fix #25718

This includes #25661 with some minor tweaks (certificate file reference was missing, and its id was wrong) and a python script.

Still need to hook that to our CI.
bors-servo added a commit that referenced this issue Mar 20, 2020
make sure UWP app can run

Fix #25718

This includes #25661 with some minor tweaks (certificate file reference was missing, and its id was wrong) and a python script.

Still need to hook that to our CI.
bors-servo added a commit that referenced this issue Mar 20, 2020
make sure UWP app can run

Fix #25718

This includes #25661 with some minor tweaks (certificate file reference was missing, and its id was wrong) and a python script.

Still need to hook that to our CI.
bors-servo added a commit that referenced this issue Mar 27, 2020
make sure UWP app can run

Fix #25718

This includes #25661 with some minor tweaks (certificate file reference was missing, and its id was wrong) and a python script.

Still need to hook that to our CI.
bors-servo added a commit that referenced this issue Mar 27, 2020
make sure UWP app can run

Fix #25718

This includes #25661 with some minor tweaks (certificate file reference was missing, and its id was wrong) and a python script.

Still need to hook that to our CI.
bors-servo added a commit that referenced this issue Mar 31, 2020
make sure UWP app can run

Fix #25718

This includes #25661 with some minor tweaks (certificate file reference was missing, and its id was wrong) and a python script.

Still need to hook that to our CI.
bors-servo added a commit that referenced this issue Apr 1, 2020
make sure UWP app can run

Fix #25718

This includes #25661 with some minor tweaks (certificate file reference was missing, and its id was wrong) and a python script.

Still need to hook that to our CI.
bors-servo added a commit that referenced this issue Apr 1, 2020
make sure UWP app can run

Fix #25718

This includes #25661 with some minor tweaks (certificate file reference was missing, and its id was wrong) and a python script.

Still need to hook that to our CI.
bors-servo added a commit that referenced this issue Apr 6, 2020
make sure UWP app can run

Fix #25718

This includes #25661 with some minor tweaks (certificate file reference was missing, and its id was wrong) and a python script.

Still need to hook that to our CI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants
You can’t perform that action at this time.