Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd a basic reftest for "hidpi" (high device-pixel-ratio) rendering #2572
Comments
|
I'd like to try this, if it still needs doing. |
|
The manifest parsing code lives in http://mxr.mozilla.org/servo/source/tests/reftest.rs#132. |
|
We support specifying the resolution on the command line: http://mxr.mozilla.org/servo/source/components/util/opts.rs#175 |
|
Is the task still valid? |
|
We're in the process of moving all of our reftests to the WPT harness, which does not support changing the resolution as far as I know (at least not on a per-test basis). |
|
@mbrubeck Can you think of a way to do this in the brave new world? |
|
My plan is to reimplement any missing features in wptrunner, fwiw. |
|
#7667 added the ability to set the resolution in Servo's custom reftest harness. We'll need to reimplement that in wptrunner in order to port |
#2549 changed the behavior of reftests to always render at 1 dppx resolution, regardless of what hardware they are running on. This means we are no longer doing any tests of higher-resolution rendering. We should add a way to specify resolution in the reftest manifest, and add some basic "sanity" tests to ensure that it doesn't break (including a
!=test to ensure that the 2x resolution rendering is different from the default 1x rendering).