Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a basic reftest for "hidpi" (high device-pixel-ratio) rendering #2572

Closed
mbrubeck opened this issue Jun 4, 2014 · 8 comments
Closed

Add a basic reftest for "hidpi" (high device-pixel-ratio) rendering #2572

mbrubeck opened this issue Jun 4, 2014 · 8 comments

Comments

@mbrubeck
Copy link
Contributor

@mbrubeck mbrubeck commented Jun 4, 2014

#2549 changed the behavior of reftests to always render at 1 dppx resolution, regardless of what hardware they are running on. This means we are no longer doing any tests of higher-resolution rendering. We should add a way to specify resolution in the reftest manifest, and add some basic "sanity" tests to ensure that it doesn't break (including a != test to ensure that the 2x resolution rendering is different from the default 1x rendering).

@mbrubeck mbrubeck added E-easy labels Jun 4, 2014
@jimberlage
Copy link
Contributor

@jimberlage jimberlage commented Oct 21, 2014

I'd like to try this, if it still needs doing.

@jdm
Copy link
Member

@jdm jdm commented Oct 21, 2014

The manifest parsing code lives in http://mxr.mozilla.org/servo/source/tests/reftest.rs#132.

@jdm
Copy link
Member

@jdm jdm commented Oct 21, 2014

We support specifying the resolution on the command line: http://mxr.mozilla.org/servo/source/components/util/opts.rs#175

@mskrzypkows
Copy link

@mskrzypkows mskrzypkows commented Nov 4, 2015

Is the task still valid?
As I understand, I have to modify parsing of manifest files to get information about used resolution, and apply it to given test. Does resolution should be specified for every single test independently? Or once per manifest file?
@jdm is the command line now present here: http://mxr.mozilla.org/servo/source/components/util/opts.rs#479 ?

@jdm
Copy link
Member

@jdm jdm commented Nov 4, 2015

We're in the process of moving all of our reftests to the WPT harness, which does not support changing the resolution as far as I know (at least not on a per-test basis).

@jdm
Copy link
Member

@jdm jdm commented Nov 4, 2015

@mbrubeck Can you think of a way to do this in the brave new world?

@Ms2ger
Copy link
Contributor

@Ms2ger Ms2ger commented Nov 4, 2015

My plan is to reimplement any missing features in wptrunner, fwiw.

@mbrubeck
Copy link
Contributor Author

@mbrubeck mbrubeck commented Nov 4, 2015

#7667 added the ability to set the resolution in Servo's custom reftest harness. We'll need to reimplement that in wptrunner in order to port tests/ref/pixel_snapping_border_a.html from the reftest harness to the WPT harness.

@Ms2ger Ms2ger closed this Jan 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.