Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upgrouping_formatter doesn't understand PRECONDITION_FAILED #25756
Comments
|
It should be straightforward to port changes from https://hg.mozilla.org/mozilla-central/rev/165dd3fa6c49c7c45770b07e979a92d583d50407 into https://github.com/servo/servo/blob/master/tests/wpt/grouping_formatter.py ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
https://hg.mozilla.org/mozilla-central/rev/165dd3fa6c49c7c45770b07e979a92d583d50407 added some new error handling to the mozlog formatters, but our custom formatter (https://github.com/servo/servo/blob/master/tests/wpt/grouping_formatter.py) needs to be updated as well. We see errors like this on CI:
I suspect it's triggered by domparsing/DOMParser-parseFromString-encoding.html but I haven't been able to reproduce it locally.