Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grouping_formatter doesn't understand PRECONDITION_FAILED #25756

Open
jdm opened this issue Feb 13, 2020 · 1 comment
Open

grouping_formatter doesn't understand PRECONDITION_FAILED #25756

jdm opened this issue Feb 13, 2020 · 1 comment
Labels

Comments

@jdm
Copy link
Member

@jdm jdm commented Feb 13, 2020

https://hg.mozilla.org/mozilla-central/rev/165dd3fa6c49c7c45770b07e979a92d583d50407 added some new error handling to the mozlog formatters, but our custom formatter (https://github.com/servo/servo/blob/master/tests/wpt/grouping_formatter.py) needs to be updated as well. We see errors like this on CI:

mozlog.structuredlog: Failure calling log handler:
Traceback (most recent call last):
  File "/repo/python/_virtualenv2.7/lib/python2.7/site-packages/mozlog/structuredlog.py", line 274, in _handle_log
    handler(data)
  File "/repo/python/_virtualenv2.7/lib/python2.7/site-packages/mozlog/handlers/base.py", line 74, in __call__
    formatted = self.formatter(data)
  File "/repo/python/_virtualenv2.7/lib/python2.7/site-packages/mozlog/handlers/base.py", line 42, in __call__
    return self.inner(item)
  File "/repo/python/_virtualenv2.7/lib/python2.7/site-packages/mozlog/reader.py", line 74, in __call__
    return handler(data)
  File "/repo/tests/wpt/grouping_formatter.py", line 205, in test_end
    self.expected[test_status] += 1
KeyError: 'PRECONDITION_FAILED'

I suspect it's triggered by domparsing/DOMParser-parseFromString-encoding.html but I haven't been able to reproduce it locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.