Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upIn immersive mode, make sure to mark the window as not visible #25794
Labels
Comments
|
We may need an api for the webxr device to tell servo if entering immersive mode obscures the browser display. |
Merged
|
The 2D window get a hidden event when entering immersive mode. |
bors-servo
added a commit
that referenced
this issue
Feb 20, 2020
Hide window Stop animations when the window is hidden. Tested with both Immersive Mode, and regular window being minimized. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #25794 (GitHub issue number if applicable)
bors-servo
added a commit
that referenced
this issue
Feb 20, 2020
Hide window Stop animations when the window is hidden. Tested with both Immersive Mode, and regular window being minimized. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #25794 (GitHub issue number if applicable)
bors-servo
added a commit
that referenced
this issue
Feb 20, 2020
Hide window Stop animations when the window is hidden. Tested with both Immersive Mode, and regular window being minimized. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #25794 (GitHub issue number if applicable)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I haven't tested yet, but we should make sure, at least in the case of the HL, that the compositor pipeline is set to not visible, to avoid useless animation to run in the background.