Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ANGLE package might be debug build #25824

Open
jdm opened this issue Feb 21, 2020 · 0 comments
Open

ANGLE package might be debug build #25824

jdm opened this issue Feb 21, 2020 · 0 comments
Labels
I-perf-slow P-windows
Projects
UWP port

Comments

@jdm
Copy link
Member

@jdm jdm commented Feb 21, 2020 

ajeffrey: So for some reason, ANGLE gets built with the /DEBUG flag even when is_debug=false
ajeffrey: Hmm, so BYUILDCONFIG.gn contains "is_debug = !is_official_build"
ajeffrey: which seems to suggest that only Official Chrome ANGLE gets to be a release build.

We should verify if this has performance implications.
@jdm jdm added this to To do in UWP port via automation Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
I-perf-slow P-windows
Projects
UWP port
  
To do
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
@jdm
You can’t perform that action at this time.