Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

text in zeit keyboard page is shown in wrong place #25828

Open
CYBAI opened this issue Feb 23, 2020 · 6 comments
Open

text in zeit keyboard page is shown in wrong place #25828

CYBAI opened this issue Feb 23, 2020 · 6 comments

Comments

@CYBAI
Copy link
Collaborator

@CYBAI CYBAI commented Feb 23, 2020

The introduction text for the page should be shown under the 3d keyboard canvas but the introduction is overlapped the canvas in Servo.

Firefox Servo
image image

(Note: the zeit logo on the top of the page is svg so it's correct that it's not shown now)

Built with ada95b9 on macOS 10.14.6

@atouchet
Copy link
Contributor

@atouchet atouchet commented Feb 26, 2020

I tried loading https://zeit.co/keyboard in Windows 10 and it didn't work. I didn't realize the keyboard was rendered with WebGL at first.

Error

Is that error sidebar new? I tried clicking on it but it just flickered in and out.

Edit: This is part of the web page, not Servo.

@CYBAI
Copy link
Collaborator Author

@CYBAI CYBAI commented Feb 26, 2020

@atouchet I guess it's an error page from zeit instead 👀

@atouchet
Copy link
Contributor

@atouchet atouchet commented Feb 26, 2020

Ah, you are right. I tried disabling WebGL in Firefox and got the same error screen:

Error

@jdm
Copy link
Member

@jdm jdm commented Feb 26, 2020

@atouchet Running with --angle on Windows should give you working webgl.

@atouchet
Copy link
Contributor

@atouchet atouchet commented Feb 27, 2020

Okay I tried reloading the page with --angle and now I get the same issue as @CYBAI.

Keyboard

@nicoabie
Copy link

@nicoabie nicoabie commented Jul 26, 2020

I get the following output

ngallinal@ITs-Mac-mini-2 servo % ./mach run https://zeit.co/keyboard        
Version: bfe8d81fb39f3363f12809c80633ac47e9a5ed58
Check out our code here: https://vercel.com/oss
Have a great day! 📣🐢
THREE.WebGLRenderer: WEBGL_depth_texture extension not supported.
THREE.WebGLRenderer: .context has been removed. Use .getContext() instead.

I think the overlapping issue is the height property on the section element.
It is height: calc(100vh - 120px)
Without that property the text is overlapped in firefox as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.