Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UWP app exits after immersive mode starts in emulator #25836

Closed
jdm opened this issue Feb 24, 2020 · 6 comments
Closed

UWP app exits after immersive mode starts in emulator #25836

jdm opened this issue Feb 24, 2020 · 6 comments

Comments

@jdm
Copy link
Member

@jdm jdm commented Feb 24, 2020

This looks like it might be a regression from #25799, or possibly a new base emulator image triggered it. The order of operations is that immersive mode starts, then the app is suspended. We happily queue a shutdown task which tells the compositor to exit, which tells the constellation to exit, which tells the script thread to exit, which tells webxr to exit, and then the app is totally shut down before any immersive content appears.

@jdm jdm added this to To do in UWP port via automation Feb 24, 2020
@jdm
Copy link
Member Author

@jdm jdm commented Feb 24, 2020

This continues to happen when I comment out the Page->Shutdown() in OnSuspend, and then none of my other breakpoints related to shutting down the compositor and constellation get hit.

@jdm
Copy link
Member Author

@jdm jdm commented Feb 24, 2020

This affects me in the HoloLens emulator, but not in a VR headset with servo/webxr#132 applied.

@paulrouget
Copy link
Contributor

@paulrouget paulrouget commented Feb 25, 2020

I can't reproduce.

Which version of the emulator?

@jdm
Copy link
Member Author

@jdm jdm commented Feb 25, 2020

10.0.18362.1053

I see it in both debug and release builds.

@paulrouget
Copy link
Contributor

@paulrouget paulrouget commented Feb 26, 2020

And does reverting #25799 help?

@jdm jdm changed the title UWP app exits after immersive mode starts UWP app exits after immersive mode starts in emulator Mar 26, 2020
@jdm
Copy link
Member Author

@jdm jdm commented May 29, 2020

This was fixed by removing the code that shut down the browser in the suspend event handler.

@jdm jdm closed this May 29, 2020
UWP port automation moved this from To do to Done May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
UWP port
  
Done
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.