Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Intermittent failure in /webaudio/the-audio-api/the-audiobuffersourcenode-interface/audiobuffersource-multi-channels.html #25840

Closed
jdm opened this issue Feb 25, 2020 · 0 comments
Closed

Intermittent failure in /webaudio/the-audio-api/the-audiobuffersourcenode-interface/audiobuffersource-multi-channels.html #25840

jdm opened this issue Feb 25, 2020 · 0 comments
Labels
I-intermittent

Comments

@jdm
Copy link
Member

@jdm jdm commented Feb 25, 2020

The failing test name contains the audio values that change each run, so it's hard to get a stables test result.
@jdm jdm added the I-intermittent label Feb 25, 2020
@jdm jdm mentioned this issue Feb 25, 2020
Merged
@khodzha khodzha mentioned this issue May 3, 2020
Merged
4 of 4 tasks complete
bors-servo added a commit that referenced this issue May 3, 2020
@bors-servo
Auto merge of #26401 - khodzha:audio-decoder-channels-indices, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
d0d431e 
fixed BaseAudioContext.DecodeAudioData progress callback

Gstreamer backend returns channel as single bit mask (ie 1, 2, 4, 8, 32 etc).
Progress callback was using this mask as plain channel index, thus storing decoded
audio in wrong channel.

(log2 conversion of int to int is subpar at best, but idk how to extract bit position in a clean way without a loop, any suggestions are welcome)

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #25840

- [X] There are tests for these changes
@bors-servo bors-servo closed this in ad212b2 May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
I-intermittent
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

fixed BaseAudioContext.DecodeAudioData progress callback
1 participant
@jdm
You can’t perform that action at this time.