Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

useless clone in layout_thread/lib.rs #25889

Closed
paulrouget opened this issue Mar 4, 2020 · 4 comments
Closed

useless clone in layout_thread/lib.rs #25889

paulrouget opened this issue Mar 4, 2020 · 4 comments
Labels
C-assigned E-easy I-cleanup

Comments

@paulrouget
Copy link
Contributor

@paulrouget paulrouget commented Mar 4, 2020

There are some useless image_cache.clone().
@paulrouget paulrouget added the E-easy label Mar 4, 2020
@highfive
Copy link

@highfive highfive commented Mar 4, 2020

Hi! If you have any questions regarding this issue, feel free to make a comment here, or ask it in the #servo channel in IRC.

If you intend to work on this issue, then add @highfive: assign me to your comment, and I'll assign this to you. 😄
@paulrouget
Copy link
Contributor Author

@paulrouget paulrouget commented Mar 4, 2020

All is needed is to remove the .clone() calls. I also believe it's the case for script_chan.
@jdm jdm added the I-cleanup label Mar 4, 2020
@iulianR
Copy link
Contributor

@iulianR iulianR commented Mar 4, 2020

@highfive: assign me
I can work on this one
@highfive
Copy link

@highfive highfive commented Mar 4, 2020

Hey @iulianR! Thanks for your interest in working on this issue. It's now assigned to you!
@highfive highfive added the C-assigned label Mar 4, 2020
@iulianR iulianR mentioned this issue Mar 4, 2020
Merged
3 of 5 tasks complete
bors-servo added a commit that referenced this issue Mar 5, 2020
@bors-servo
Auto merge of #25896 - iulianR:issue-25889, r=paulrouget
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
3324a73 
Remove unnecessary .clone() calls

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #25889 (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo bors-servo closed this in d5724cc Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-assigned E-easy I-cleanup
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Remove unnecessary .clone() calls
4 participants
@jdm @paulrouget @highfive @iulianR
You can’t perform that action at this time.