Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skulls demo doesn't render anything in immersive mode #25895

Closed
jdm opened this issue Mar 4, 2020 · 5 comments
Closed

skulls demo doesn't render anything in immersive mode #25895

jdm opened this issue Mar 4, 2020 · 5 comments
Labels
Projects

Comments

@jdm
Copy link
Member

@jdm jdm commented Mar 4, 2020

I see content in the windowed mode, but nothing appears around me when I enter immersive mode.

@jdm jdm added the A-xr-zomg label Mar 4, 2020
@atouchet atouchet added this to To do in HoloLens Mar 5, 2020
@paulrouget
Copy link
Contributor

@paulrouget paulrouget commented Mar 5, 2020

That's a regression. This used to work.

@paulrouget
Copy link
Contributor

@paulrouget paulrouget commented Mar 11, 2020

JS error controller.vrController.gamepadController is undefined not in babylonjs, but in the demo itself. And the fix for the demo was made for the webvr API, not webxr. I think this used to work before the introduction of the pointer support in the demo.

I'll be talking to the bbjs people about this.

@paulrouget
Copy link
Contributor

@paulrouget paulrouget commented Mar 13, 2020

Note to self:

The BBJS demo has been updated for webvr, but not webxr. Webxr works differently (no more vr controller). It is documented here: https://doc.babylonjs.com/how_to/webxr_controllers_support. The difference between vr and xr is documented here https://doc.babylonjs.com/how_to/introduction_to_webxr#migrating-from-webvr , not everything is up to date (like, motionController is an async operation)

@paulrouget
Copy link
Contributor

@paulrouget paulrouget commented Mar 17, 2020

Tried to make it work, but the demo was initially designed for WebVR. I talked with Raanan, and we are going to remove this demo, and I will add 3 new demos, up to date with WebXR API and the latest babylonjs version:

@paulrouget
Copy link
Contributor

@paulrouget paulrouget commented Mar 25, 2020

We removed the demo.

@paulrouget paulrouget closed this Mar 25, 2020
@atouchet atouchet moved this from To do to Done in HoloLens Mar 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
HoloLens
  
Done
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.