Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vslogger only checks for exact module string matches #25997

Closed
jdm opened this issue Mar 19, 2020 · 0 comments
Closed

vslogger only checks for exact module string matches #25997

jdm opened this issue Mar 19, 2020 · 0 comments
Labels
A-embedding
Projects
HoloLens

Comments

@jdm
Copy link
Member

@jdm jdm commented Mar 19, 2020

Adding a filter like net silently doesn't work, rather than showing all of the entries under the net crate.
@jdm jdm added the A-embedding label Mar 19, 2020
@paulrouget paulrouget mentioned this issue Mar 23, 2020
Merged
3 of 3 tasks complete
bors-servo added a commit that referenced this issue Mar 23, 2020
@bors-servo
Auto merge of #26011 - paulrouget:vslog.submods, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
f6a5ca5 
UWP: include submodule logs

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #25997 (GitHub issue number if applicable)
bors-servo added a commit that referenced this issue Mar 24, 2020
@bors-servo
Auto merge of #26011 - paulrouget:vslog.submods, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
a3b1594 
UWP: include submodule logs

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #25997 (GitHub issue number if applicable)
@atouchet atouchet added this to Done in HoloLens Mar 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-embedding
Projects
HoloLens
  
Done
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

UWP: include submodule logs
1 participant
@jdm
You can’t perform that action at this time.