Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add InRealm argument to Callback trait #26007

Closed
jdm opened this issue Mar 20, 2020 · 2 comments
Closed

Add InRealm argument to Callback trait #26007

jdm opened this issue Mar 20, 2020 · 2 comments
Labels
A-content/bindings C-assigned I-refactor

Comments

@jdm
Copy link
Member

@jdm jdm commented Mar 20, 2020

Callers need to have entered a realm, so we should make the compiler check that for us.
@tipowol
Copy link
Contributor

@tipowol tipowol commented Apr 5, 2020

@highfive assign me
@highfive
Copy link

@highfive highfive commented Apr 5, 2020

Hey @tipowol! Thanks for your interest in working on this issue. It's now assigned to you!
@highfive highfive added the C-assigned label Apr 5, 2020
@tipowol tipowol mentioned this issue Apr 5, 2020
Merged
4 of 4 tasks complete
bors-servo added a commit that referenced this issue Apr 6, 2020
@bors-servo
Auto merge of #26116 - tipowol:fix-26007, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
0a99fa1 
Add InRealm argument to Callback trait

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #26007
- [x] There are tests for these changes
bors-servo added a commit that referenced this issue Apr 6, 2020
@bors-servo
Auto merge of #26116 - tipowol:fix-26007, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
51f1038 
Add InRealm argument to Callback trait

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #26007
- [x] There are tests for these changes
@bors-servo bors-servo closed this in 8126c9d Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/bindings C-assigned I-refactor
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Add InRealm argument to Callback trait
3 participants
@jdm @highfive @tipowol
You can’t perform that action at this time.