Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

webgl2 particles demo doesn't animate #26137

Closed
jdm opened this issue Apr 7, 2020 · 0 comments
Closed

webgl2 particles demo doesn't animate #26137

jdm opened this issue Apr 7, 2020 · 0 comments
Labels
A-content/webgl

Comments

@jdm
Copy link
Member

@jdm jdm commented Apr 7, 2020

http://toji.github.io/webgl2-particles-2/

Run with --pref dom.webgl2.enabled
@jdm jdm added the A-content/webgl label Apr 7, 2020
@jdm jdm mentioned this issue Apr 8, 2020
Merged
4 of 4 tasks complete
bors-servo added a commit that referenced this issue Apr 8, 2020
@bors-servo
Auto merge of #26143 - jdm:transform-feedback, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
e659e62 
Fix webgl transform feedback

This allows https://www.joshmatthews.net/webxr-particles/ to run in Servo. This change corresponds with the following spec text:
```
GL_INVALID_OPERATION is generated by glBeginTransformFeedback if no binding points would be used, either because no program object is active of because the active program object has specified no varying variables to record.
```

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #26137
- [x] There are tests for these changes
bors-servo added a commit that referenced this issue Apr 15, 2020
@bors-servo
Auto merge of #26143 - jdm:transform-feedback, r=nox
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
a8379a3 
Fix webgl transform feedback

This allows https://www.joshmatthews.net/webxr-particles/ to run in Servo. This change corresponds with the following spec text:
```
GL_INVALID_OPERATION is generated by glBeginTransformFeedback if no binding points would be used, either because no program object is active of because the active program object has specified no varying variables to record.
```

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #26137
- [x] There are tests for these changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/webgl
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Fix webgl transform feedback
1 participant
@jdm
You can’t perform that action at this time.