Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LineWidth with non-1.0 value in webgl 2 contexts can cause a GL panic #26139

Closed
jdm opened this issue Apr 8, 2020 · 0 comments
Closed

LineWidth with non-1.0 value in webgl 2 contexts can cause a GL panic #26139

jdm opened this issue Apr 8, 2020 · 0 comments
Labels
A-content/webgl I-panic

Comments

@jdm
Copy link
Member

@jdm jdm commented Apr 8, 2020

https://stackoverflow.com/questions/8791531/opengl-3-2-core-profile-gllinewidth
https://community.khronos.org/t/gllinewidth-gives-gl-invalid-value-for-widths-1/69023

This is explicitly deprecated in later versions of the GL Core profile, and macOS seems to trigger it on 3.2 and greater.
@jdm jdm mentioned this issue Apr 8, 2020
Merged
3 of 3 tasks complete
bors-servo added a commit that referenced this issue Apr 8, 2020
@bors-servo
Auto merge of #26147 - jdm:linewidth, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
dc01d4c 
Avoid GL errors with LineWidth commands

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #26139
bors-servo added a commit that referenced this issue Apr 14, 2020
@bors-servo
Auto merge of #26147 - jdm:linewidth, r=nox
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
a85dc77 
Avoid GL errors with LineWidth commands

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #26139
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/webgl I-panic
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Avoid GL errors with LineWidth commands
1 participant
@jdm
You can’t perform that action at this time.