Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add origin trials for webgl 2 #26144

Closed
jdm opened this issue Apr 8, 2020 · 1 comment
Closed

Add origin trials for webgl 2 #26144

jdm opened this issue Apr 8, 2020 · 1 comment

Comments

@jdm
Copy link
Member

@jdm jdm commented Apr 8, 2020

Our WebGL 2 implementation is not yet at the point where we can enable it by default (in particular, there are problems like #26142). However, for demos that require WebGL 2 and run correctly with it enabled like http://joshmatthews.net/webxr-particles/, we should add support for enabling it on known-good origins. We can do this by using a Func annotation instead of Pref in the various webgl2 WebIDL files, and the function can first check the preference, and then fall back to comparing the global's origin against a list of known good origins.

@jdm
Copy link
Member Author

@jdm jdm commented Apr 22, 2020

Implemented in #26191.

@jdm jdm closed this Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.