Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide embedder feedback if openxr backend isn't set up right #26213

Closed
jdm opened this issue Apr 17, 2020 · 1 comment
Closed

Provide embedder feedback if openxr backend isn't set up right #26213

jdm opened this issue Apr 17, 2020 · 1 comment

Comments

@jdm
Copy link
Member

@jdm jdm commented Apr 17, 2020

Ideally we should pop up some kind of message dialog either on startup or when entering VR/AR fails. This requires some kind of coordination between the webxr backend, the DOM XR code, and the embedding API.

@jdm jdm added the A-embedding label Apr 17, 2020
@jdm jdm added this to To do in UWP port via automation Apr 17, 2020
@jdm
Copy link
Member Author

@jdm jdm commented Apr 24, 2020

This is a bad enough experience that we should definitely fix it before publicizing our desktop UWP builds to a wider audience. It's really easy to forget to tell people to set up OpenXR first, and the experience of having a runtime that isn't enabled appears to be that xrCreateInstance returns XR_ERROR_INSTANCE_LOST.

@jdm jdm added the I-papercut label Apr 24, 2020
@jdm jdm mentioned this issue Apr 24, 2020
4 of 4 tasks complete
bors-servo added a commit that referenced this issue Apr 24, 2020
Provide feedback when OpenXR can't start

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #26213
- [x] These changes do not require tests because it's testing an edge case in an environment we can't test on CI
bors-servo added a commit that referenced this issue Apr 24, 2020
Provide feedback when OpenXR can't start

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #26213
- [x] These changes do not require tests because it's testing an edge case in an environment we can't test on CI
UWP port automation moved this from To do to Done Apr 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
UWP port
  
Done
Linked pull requests

Successfully merging a pull request may close this issue.

1 participant
You can’t perform that action at this time.