Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libsimpleservo docs aren't present on doc.servo.org #26235

Open
jdm opened this issue Apr 20, 2020 · 1 comment
Open

libsimpleservo docs aren't present on doc.servo.org #26235

jdm opened this issue Apr 20, 2020 · 1 comment

Comments

@jdm
Copy link
Member

@jdm jdm commented Apr 20, 2020

We chould generate the docs with a --libsimpleservo build, but that would cut out the docs from ports/glutin. It would be nice if there were a way to merge the two builds somehow.

@SimonSapin
Copy link
Member

@SimonSapin SimonSapin commented Apr 20, 2020

What happens if we run both cargo doc commands? I expect files that have the same path and name will be overwritten by the second command, but no file will be deleted. (Note that cargo doc shares compiler artifacts with cargo check but not with cargo build.)

It’d be easiest to try locally because CI doesn’t (by default) upload docs anywhere easily browsable unless a PR is merged into master, but once we have a series of commands that produces the desired output it can be put here to change https://doc.servo.org/:

RUSTDOCFLAGS="--disable-minification" ./mach doc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.