Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reveal.js keyboard navigation is broken #26252

Closed
asajeffrey opened this issue Apr 21, 2020 · 1 comment
Closed

Reveal.js keyboard navigation is broken #26252

asajeffrey opened this issue Apr 21, 2020 · 1 comment
Labels
A-content/script A-webcompat

Comments

@asajeffrey
Copy link
Member

@asajeffrey asajeffrey commented Apr 21, 2020

Point servo at https://revealjs.com (or any other site using reveal) and keyboard navigation doesn't work. The culprit is https://github.com/hakimel/reveal.js/blob/00b0ace3863952ce95df4430d203686fd27bfc20/js/reveal.js#L5233 which checks for editable elements using document.activeElement.contentEditable !== 'inherit' rather than document.activeElement.iscontentEditable. With that change, reveal works.

Related: #12776
@asajeffrey asajeffrey mentioned this issue Apr 21, 2020
Merged
3 of 3 tasks complete
@asajeffrey
Copy link
Member Author

@asajeffrey asajeffrey commented Apr 22, 2020

Fixed upstream by hakimel/reveal.js#2650 and a workaround is #26253.
@asajeffrey asajeffrey closed this Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/script A-webcompat
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
@asajeffrey
You can’t perform that action at this time.