Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Intermittent error in /webxr/hit-test/ar_hittest_subscription_inputSources.https.html #26347

Closed
jdm opened this issue Apr 28, 2020 · 5 comments
Closed

Intermittent error in /webxr/hit-test/ar_hittest_subscription_inputSources.https.html #26347

jdm opened this issue Apr 28, 2020 · 5 comments
Labels
A-xr-zomg I-intermittent

Comments

@jdm
Copy link
Member

@jdm jdm commented Apr 28, 2020 

  ▶ ERROR [expected OK] /webxr/hit-test/ar_hittest_subscription_inputSources.https.html
  │   → input_source is undefined
  │ 
  └ testFunction/</</<@https://web-platform.test:8443/webxr/hit-test/ar_hittest_subscription_inputSources.https.html:66:11

cc @Manishearth
@Manishearth
Copy link
Member

@Manishearth Manishearth commented Apr 28, 2020

This is probably happening because of a race between simulateInputSource() and the rAF. That function is supposed to run by the next animation frame, but at that point we have been silently ticking the frame loop so sometimes a queued up raf ends up running instead.

It's a bit annoying to fix, though. We could potentially have it process frames a little bit differently in the mock implementation.
@Manishearth
Copy link
Member

@Manishearth Manishearth commented Apr 30, 2020

This is easier to fix in the tests, IMO

immersive-web/webxr-test-api#64
@Manishearth
Copy link
Member

@Manishearth Manishearth commented Apr 30, 2020

This will be fixed in the tests, though I'd wait for https://chromium-review.googlesource.com/c/chromium/src/+/2173519 to land before actually fixing the tests.
@Manishearth Manishearth mentioned this issue Apr 30, 2020
Merged
@Manishearth
Copy link
Member

@Manishearth Manishearth commented Apr 30, 2020

Fixed the races in the tests: web-platform-tests/wpt#23350

should be a few days for this to land; we're waiting on a different WPT change to land and sync from Chromium.
stephenmcgruer pushed a commit to web-platform-tests/wpt that referenced this issue May 1, 2020
@Manishearth
Use requestSkipAnimationFrame to avoid races in tests (#23350)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
a4d70f1 
See immersive-web/webxr-test-api#64 : the current usage is racy, tests should requestSkipAnimationFrame() after manipulating fakeDeviceController outside of the rAF loop.

Would like to allow https://chromium-review.googlesource.com/c/chromium/src/+/2173519 to land and sync before landing this, to avoid manifest merge conflicts and further headaches for Alex 😄

fixes servo/servo#26347
@Manishearth
Copy link
Member

@Manishearth Manishearth commented May 2, 2020

Merged upstream
@Manishearth Manishearth closed this May 2, 2020
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue May 15, 2020
@Manishearth @moz-wptsync-bot
Bug 1634575 [wpt PR 23350] - Use requestSkipAnimationFrame to avoid r…
d457d4f 
…aces in tests, a=testonly

Automatic update from web-platform-tests
Use requestSkipAnimationFrame to avoid races in tests (#23350)

See immersive-web/webxr-test-api#64 : the current usage is racy, tests should requestSkipAnimationFrame() after manipulating fakeDeviceController outside of the rAF loop.

Would like to allow https://chromium-review.googlesource.com/c/chromium/src/+/2173519 to land and sync before landing this, to avoid manifest merge conflicts and further headaches for Alex 😄

fixes servo/servo#26347
--

wpt-commits: a4d70f161fdb2e59e994e09fe142a880fb0b1d0e
wpt-pr: 23350
xeonchen pushed a commit to xeonchen/gecko that referenced this issue May 15, 2020
@Manishearth @moz-wptsync-bot
Bug 1634575 [wpt PR 23350] - Use requestSkipAnimationFrame to avoid r…
e69d843 
…aces in tests, a=testonly

Automatic update from web-platform-tests
Use requestSkipAnimationFrame to avoid races in tests (#23350)

See immersive-web/webxr-test-api#64 : the current usage is racy, tests should requestSkipAnimationFrame() after manipulating fakeDeviceController outside of the rAF loop.

Would like to allow https://chromium-review.googlesource.com/c/chromium/src/+/2173519 to land and sync before landing this, to avoid manifest merge conflicts and further headaches for Alex 😄

fixes servo/servo#26347
--

wpt-commits: a4d70f161fdb2e59e994e09fe142a880fb0b1d0e
wpt-pr: 23350
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue May 20, 2020
@Manishearth @moz-wptsync-bot
Bug 1634575 [wpt PR 23350] - Use requestSkipAnimationFrame to avoid r…
61f08fb 
…aces in tests, a=testonly

Automatic update from web-platform-tests
Use requestSkipAnimationFrame to avoid races in tests (#23350)

See immersive-web/webxr-test-api#64 : the current usage is racy, tests should requestSkipAnimationFrame() after manipulating fakeDeviceController outside of the rAF loop.

Would like to allow https://chromium-review.googlesource.com/c/chromium/src/+/2173519 to land and sync before landing this, to avoid manifest merge conflicts and further headaches for Alex 😄

fixes servo/servo#26347
--

wpt-commits: a4d70f161fdb2e59e994e09fe142a880fb0b1d0e
wpt-pr: 23350
xeonchen pushed a commit to xeonchen/gecko that referenced this issue May 20, 2020
@Manishearth @moz-wptsync-bot
Bug 1634575 [wpt PR 23350] - Use requestSkipAnimationFrame to avoid r…
d0eb5d4 
…aces in tests, a=testonly

Automatic update from web-platform-tests
Use requestSkipAnimationFrame to avoid races in tests (#23350)

See immersive-web/webxr-test-api#64 : the current usage is racy, tests should requestSkipAnimationFrame() after manipulating fakeDeviceController outside of the rAF loop.

Would like to allow https://chromium-review.googlesource.com/c/chromium/src/+/2173519 to land and sync before landing this, to avoid manifest merge conflicts and further headaches for Alex 😄

fixes servo/servo#26347
--

wpt-commits: a4d70f161fdb2e59e994e09fe142a880fb0b1d0e
wpt-pr: 23350
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-xr-zomg I-intermittent
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Use requestSkipAnimationFrame to avoid races in tests
2 participants
@jdm @Manishearth
You can’t perform that action at this time.