Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treat referrerpolicy attribute as a "relevant mutation" for image elements #26388

Closed
jdm opened this issue May 1, 2020 · 3 comments
Closed

Treat referrerpolicy attribute as a "relevant mutation" for image elements #26388

jdm opened this issue May 1, 2020 · 3 comments
Labels
A-content/dom C-assigned E-easy I-spec-update

Comments

@jdm
Copy link
Member

@jdm jdm commented May 1, 2020

Spec change: whatwg/html#5434
Tests: web-platform-tests/wpt#23309
Code:

servo/components/script/dom/htmlimageelement.rs

Lines 1592 to 1599 in 64dee1f

fn attribute_mutated(&self, attr: &Attr, mutation: AttributeMutation) {
self.super_type().unwrap().attribute_mutated(attr, mutation);
match attr.local_name() {
&local_name!("src") |
&local_name!("srcset") |
&local_name!("width") |
&local_name!("crossorigin") |
&local_name!("sizes") => self.update_the_image_data(),

We should hopefully see new test results if we run ./mach test-wpt tests/wpt/web-platform-tests/html/semantics/embedded-content/the-img-element/relevant-mutations.html after adding the attribute to the list of attributes that cause the image data to be updated.
@highfive
Copy link

@highfive highfive commented May 1, 2020

Hi! If you have any questions regarding this issue, feel free to make a comment here, or ask it in the #servo channel in Matrix.

If you intend to work on this issue, then add @highfive: assign me to your comment, and I'll assign this to you. 😄
@jdm jdm added the I-spec-update label May 1, 2020
@PeterZhizhin
Copy link
Contributor

@PeterZhizhin PeterZhizhin commented May 3, 2020

@highfive: assign me
@highfive highfive added the C-assigned label May 3, 2020
@highfive
Copy link

@highfive highfive commented May 3, 2020

Hey @PeterZhizhin! Thanks for your interest in working on this issue. It's now assigned to you!
PeterZhizhin added a commit to PeterZhizhin/servo that referenced this issue May 6, 2020
@PeterZhizhin
Added referrerpolicy as relevant mutation for img
baf9850 
This fixes servo#26388. referrerPolicy is now calls onload for image
mutations. Not all referrerPolicy attribute changes result in an image
update event. Only valid changes are reflected.

Referrerpolicy tests now pass.
@PeterZhizhin PeterZhizhin mentioned this issue May 6, 2020
Merged
4 of 4 tasks complete
bors-servo added a commit that referenced this issue May 6, 2020
@bors-servo
Auto merge of #26450 - PeterZhizhin:add_referrerpolicy_to_list_of_rel…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
2ecb409 
…evant_mutations, r=<try>

Add referrerpolicy to list of relevant mutations

<!-- Please describe your changes on the following line: -->

`img.referrerPolicy` change now mutates the image.
Not all `referrerPolicy` attribute changes result in an image update event.
Only valid changes are reflected.

All referrerpolicy tests inside `relevant-mutations.html` WPT test now pass.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #26388

<!-- Either: -->
- [x] These have tests:
```
./mach test-wpt tests/wpt/web-platform-tests/html/semantics/embedded-content/the-img-element/relevant-mutations.html
```
bors-servo added a commit that referenced this issue May 6, 2020
@bors-servo
Auto merge of #26450 - PeterZhizhin:add_referrerpolicy_to_list_of_rel…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
2f80db3 
…evant_mutations, r=<try>

Add referrerpolicy to list of relevant mutations

<!-- Please describe your changes on the following line: -->

`img.referrerPolicy` change now mutates the image.
Not all `referrerPolicy` attribute changes result in an image update event.
Only valid changes are reflected.

All referrerpolicy tests inside `relevant-mutations.html` WPT test now pass.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #26388

<!-- Either: -->
- [x] These have tests:
```
./mach test-wpt tests/wpt/web-platform-tests/html/semantics/embedded-content/the-img-element/relevant-mutations.html
```
bors-servo added a commit that referenced this issue May 7, 2020
@bors-servo
Auto merge of #26450 - PeterZhizhin:add_referrerpolicy_to_list_of_rel…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
6aec2c8 
…evant_mutations, r=jdm

Add referrerpolicy to list of relevant mutations

<!-- Please describe your changes on the following line: -->

`img.referrerPolicy` change now mutates the image.
Not all `referrerPolicy` attribute changes result in an image update event.
Only valid changes are reflected.

All referrerpolicy tests inside `relevant-mutations.html` WPT test now pass.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #26388

<!-- Either: -->
- [x] These have tests:
```
./mach test-wpt tests/wpt/web-platform-tests/html/semantics/embedded-content/the-img-element/relevant-mutations.html
```
@bors-servo bors-servo closed this in f44c2c9 May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/dom C-assigned E-easy I-spec-update
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Add referrerpolicy to list of relevant mutations
3 participants
@jdm @PeterZhizhin @highfive
You can’t perform that action at this time.