Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<br> doesn't force a line break #26440

Closed
jdm opened this issue May 5, 2020 · 3 comments
Closed

<br> doesn't force a line break #26440

jdm opened this issue May 5, 2020 · 3 comments
Labels
A-layout/2020

Comments

@jdm
Copy link
Member

@jdm jdm commented May 5, 2020

Testcase:

hello<br>there

yields
Screen Shot 2020-05-05 at 6 46 58 PM
@jdm jdm added the A-layout/2020 label May 5, 2020
@jdm
Copy link
Member Author

@jdm jdm commented May 5, 2020

Adding <style>br::before { content: "hi\A" }</style> yields hellohi there, so the code that linebreaks on whitespace is missing.
@jdm
Copy link
Member Author

@jdm jdm commented May 6, 2020

More specifically, layout-2013 supports the various white-space CSS values, and user-agent.css contains br::before { content: "\A"; white-space: pre }. layout-2020 supports the content property and inserts the whitespace, but doesn't handle white-space values like pre that would force a line break at this point.
@jdm
Copy link
Member Author

@jdm jdm commented May 6, 2020

https://drafts.csswg.org/css2/text.html#white-space-model
@jdm jdm mentioned this issue May 6, 2020
Merged
4 of 4 tasks complete
bors-servo added a commit that referenced this issue May 6, 2020
@bors-servo
Auto merge of #26447 - jdm:white-space-2020, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
b73c92c 
Layout 2020: Implement basic white-space: pre support

With these changes `<pre>` and `<br>` preserve spaces and force line breaks appropriately.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #26440
- [x] There are tests for these changes
@jdm jdm mentioned this issue Jun 2, 2020
Open
bors-servo added a commit that referenced this issue Jul 24, 2020
@bors-servo
Auto merge of #26447 - jdm:white-space-2020, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
dc737cc 
Layout 2020: Implement basic white-space: pre support

With these changes `<pre>` and `<br>` preserve spaces and force line breaks appropriately.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #26440
- [x] There are tests for these changes
bors-servo added a commit that referenced this issue Jul 24, 2020
@bors-servo
Auto merge of #26447 - jdm:white-space-2020, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
378993a 
Layout 2020: Implement basic white-space: pre support

With these changes `<pre>` and `<br>` preserve spaces and force line breaks appropriately.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #26440
- [x] There are tests for these changes
bors-servo added a commit that referenced this issue Jul 27, 2020
@bors-servo
Auto merge of #26447 - jdm:white-space-2020, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
1db03cd 
Layout 2020: Implement basic white-space: pre support

With these changes `<pre>` and `<br>` preserve spaces and force line breaks appropriately.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #26440
- [x] There are tests for these changes
bors-servo added a commit that referenced this issue Jul 28, 2020
@bors-servo
Auto merge of #26447 - jdm:white-space-2020, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
86383d9 
Layout 2020: Implement basic white-space: pre support

With these changes `<pre>` and `<br>` preserve spaces and force line breaks appropriately.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #26440
- [x] There are tests for these changes
bors-servo added a commit that referenced this issue Jul 29, 2020
@bors-servo
Auto merge of #26447 - jdm:white-space-2020, r=nox
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
89d1cf2 
Layout 2020: Implement basic white-space: pre support

With these changes `<pre>` and `<br>` preserve spaces and force line breaks appropriately.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #26440
- [x] There are tests for these changes
bors-servo added a commit that referenced this issue Jul 29, 2020
@bors-servo
Auto merge of #26447 - jdm:white-space-2020, r=nox
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
544c379 
Layout 2020: Implement basic white-space: pre support

With these changes `<pre>` and `<br>` preserve spaces and force line breaks appropriately.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #26440
- [x] There are tests for these changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-layout/2020
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Layout 2020: Implement basic white-space: pre support
1 participant
@jdm
You can’t perform that action at this time.