Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement referrerPolicy IDL attribute for HTMLScriptElement and HTMLLinkElement #26454

Open
jdm opened this issue May 6, 2020 · 3 comments
Open

Comments

@jdm jdm changed the title Implement referrerPolicy IDL attribute for HTMLScriptElement Implement referrerPolicy IDL attribute for HTMLScriptElement and HTMLLinkElement May 6, 2020
@nosark
Copy link
Contributor

@nosark nosark commented May 21, 2020

I would like to work on this issue please

@jdm
Copy link
Member Author

@jdm jdm commented May 21, 2020

@nosark Great! This will require updating the webidl files for both interfaces to add the missing IDL attribute, then implementing the getters and setters for both HTMLScriptElement and HTMLLinkElement. For the getters you will want to extract the first few lines of referrer_policy_for_element into a helper function, and the setters can use the make_setter! macro like any other string-reflecting attribute. Finally, code like this for each element should call referrer_policy_for_element so that the proper values are used.

@nosark
Copy link
Contributor

@nosark nosark commented May 21, 2020

@jdm Okay, awesome! Thank you!

@gterzian gterzian added the C-assigned label May 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.