Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upText animation doesn't stop #26460
Closed
Text animation doesn't stop #26460
Assignees
Labels
Comments
|
This regression is likely due to #26362. cc @mrobinson |
|
Reduced test case: <style>
.paragraph {
opacity: 0;
animation: fade-in 600ms ease-in forwards;
animation-delay: 0.5s;
}
@keyframes fade-in {
to { opacity:1; }
}
</style>
<p class="paragraph">Animating Text</p>The issue is we are no longer keeping animations around after they finish so they infinitely retrigger. This should theoretically be fixed by proper implementation of |
mrobinson
added a commit
to mrobinson/servo
that referenced
this issue
May 13, 2020
Fixes servo#26460.
mrobinson
added a commit
to mrobinson/servo
that referenced
this issue
May 14, 2020
Fixes servo#26460.
bors-servo
added a commit
that referenced
this issue
May 16, 2020
…,emilio Implement `animation-fill-mode` Fixes #26460. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
mrobinson
added a commit
to mrobinson/servo
that referenced
this issue
May 17, 2020
Fixes servo#26460.
bors-servo
added a commit
that referenced
this issue
May 17, 2020
…,emilio Implement `animation-fill-mode` Fixes #26460. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
bors-servo
added a commit
that referenced
this issue
May 17, 2020
Implement `animation-fill-mode` Fixes #26460. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
URL: https://vercel.com/keyboard
Steps to reproduce:
This issue first occurred in the 2020-05-02 nightly build. Tested in Windows 10.
Regression range: 6fb75c2...d08c4ff