Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upCreate an embedding-specific about:failure #26523
Closed
Labels
Projects
Comments
Merged
bors-servo
added a commit
that referenced
this issue
Aug 4, 2020
UWP Crash reporter This is supposed to address #27167 and #26523. Also fix #27435. These changes are still WIP as I found a few bugs, it needs more testing and the actual code to upload is not implemented yet. But I'd like to get an early feedback. First, panics are caught via `panic::set_hook` instead of `catch_unwind` allowing us to catch more panics. We also now report panics reported via the `Embedder:Panic` message. Once the panic is caught, if possible, we try to recover. I haven't found a way to recover when the panic is caught is a non-GL thread. We need a generic way to throw from the UWP code, and even trying to add a UnhandledEvent handler doesn't appear to work. Once a panic is caught (even if we can not recover) a crash-report file is created, including the backtrace, stdout, and the current url. If the app did not crash at that point, or after a restart if it did, we check if the crash report file is present, and if so, we present a panel to the user to allow them to upload the report. At that point the user can also add details to the report. <img width="1079" alt="Screen Shot 2020-07-29 at 12 35 44" src="https://user-images.githubusercontent.com/373579/88790406-6d777180-d198-11ea-9237-6f80dc9d0340.png">
|
Fixed by #27438. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
For the UWP application, it would be nice to load a "Ooops, something went wrong" page when panics occur. We already load
about:failurewhich doesn't actually exist, so this "just" needs some plumbing from the embedder layer to provide meaningful content.