Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module metadata hook is missing #26542

Closed
jdm opened this issue May 15, 2020 · 2 comments
Closed

Module metadata hook is missing #26542

jdm opened this issue May 15, 2020 · 2 comments

Comments

@jdm
Copy link
Member

@jdm jdm commented May 15, 2020

https://mixedreality.mozilla.org/area-demo-service-task/ fails immedidately with:

[2020-05-15T15:03:16Z ERROR script::dom::bindings::error] Error at https://mixedreality.mozilla.org/area-demo-service-task/arosg.js:3:20 Module metadata hook not set

This comes from https://searchfox.org/mozilla-central/rev/4166c15e2a99a23a9b38ad62c9fdfe8e5448b354/js/src/builtin/ModuleObject.cpp#1697, which is triggered by

SetModuleMetadataHook(rt, None);
. We should port the equivalent code from Gecko instead.

@jdm
Copy link
Member Author

@jdm jdm commented May 15, 2020

@CYBAI You might be interested in this.

@CYBAI
Copy link
Collaborator

@CYBAI CYBAI commented May 16, 2020

@jdm Thanks! I will look into it!

@CYBAI CYBAI mentioned this issue May 16, 2020
4 of 4 tasks complete
bors-servo added a commit that referenced this issue May 17, 2020
Introduce import.meta hook for module script

<!-- Please describe your changes on the following line: -->

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #26542
- [x] There are tests for these changes under `module/import-meta` folder.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
You can’t perform that action at this time.