Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Body IDL harness tests failing while interfaces appear implemented #26724

Open
gterzian opened this issue May 31, 2020 · 3 comments
Open

Body IDL harness tests failing while interfaces appear implemented #26724

gterzian opened this issue May 31, 2020 · 3 comments

Comments

@gterzian
Copy link
Member

@gterzian gterzian commented May 31, 2020

https://github.com/servo/servo/blob/14303bd651e248e6e7a73759d622658088f9ddf1/tests/wpt/metadata/fetch/api/idlharness.any.js.ini

While Response and Request both implement the Body mixin(see methods like Json).

Not sure why.

@jdm
Copy link
Member

@jdm jdm commented Jun 3, 2020

Which specific test failures in the ini file are you referring to here?

@jdm
Copy link
Member

@jdm jdm commented Jun 3, 2020

I tried commenting out some of the metadata entries for blob/formdata etc.

  FAIL Response interface: operation blob() - assert_unreached: Throws "TypeError: "this" object does not implement interface Response." instead of rejecting promise Reached unreachable code
throwOrReject/<@http://web-platform.test:8000/resources/idlharness.js:116:33
Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1977:25
throwOrReject@http://web-platform.test:8000/resources/idlharness.js:115:20
IdlInterface.prototype.do_member_operation_asserts@http://web-platform.test:8000/resources/idlharness.js:2551:26
IdlInterface.prototype.test_member_operation/<@http://web-platform.test:8000/resources/idlharness.js:2471:14
Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1977:25
IdlInterface.prototype.test_member_operation@http://web-platform.test:8000/resources/idlharness.js:2419:12
IdlInterface.prototype.test_members@http://web-platform.test:8000/resources/idlharness.js:2729:26
IdlInterface.prototype.test@http://web-platform.test:8000/resources/idlharness.js:1587:10
IdlArray.prototype.test@http://web-platform.test:8000/resources/idlharness.js:906:28
idl_test/</<@http://web-platform.test:8000/resources/idlharness.js:3470:31
  FAIL Response interface: operation formData() - assert_unreached: Throws "TypeError: "this" object does not implement interface Response." instead of rejecting promise Reached unreachable code
throwOrReject/<@http://web-platform.test:8000/resources/idlharness.js:116:33
Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1977:25
throwOrReject@http://web-platform.test:8000/resources/idlharness.js:115:20
IdlInterface.prototype.do_member_operation_asserts@http://web-platform.test:8000/resources/idlharness.js:2551:26
IdlInterface.prototype.test_member_operation/<@http://web-platform.test:8000/resources/idlharness.js:2471:14
Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1977:25
IdlInterface.prototype.test_member_operation@http://web-platform.test:8000/resources/idlharness.js:2419:12
IdlInterface.prototype.test_members@http://web-platform.test:8000/resources/idlharness.js:2729:26
IdlInterface.prototype.test@http://web-platform.test:8000/resources/idlharness.js:1587:10
IdlArray.prototype.test@http://web-platform.test:8000/resources/idlharness.js:906:28
idl_test/</<@http://web-platform.test:8000/resources/idlharness.js:3470:31

I suspect that this is another example of a test failure caused by #26774, given those error messages.

@jdm jdm added this to To do in web-platform-test failures via automation Jun 3, 2020
@gterzian
Copy link
Member Author

@gterzian gterzian commented Jun 4, 2020

Yes looks like it would be that issue(I was referring to the various methods like json, formData, and blob which are implemented and still fail the harness, and they do return promises).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.