Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforcing formatting of TOML files #26728

Open
atouchet opened this issue May 31, 2020 · 4 comments
Open

Enforcing formatting of TOML files #26728

atouchet opened this issue May 31, 2020 · 4 comments

Comments

@atouchet
Copy link
Contributor

@atouchet atouchet commented May 31, 2020

Currently having consistent formatting is not enforced for TOML files and as a result they have tended to become a bit disorganized. I have manually cleaned up a number of them recently to have mostly consistent formatting but things still aren't quite perfect. Would there be any interest in enforcing formatting standards for these files or would that just be more of a nuisance?

@jdm
Copy link
Member

@jdm jdm commented May 31, 2020

If there's automatic tooling for it, I think it would be useful.

@atouchet
Copy link
Contributor Author

@atouchet atouchet commented May 31, 2020

This GitHub issue appears to have some related info about tooling: toml-lang/toml#532

@SimonSapin
Copy link
Member

@SimonSapin SimonSapin commented May 31, 2020

This could be integrated with ./mach test-tidy for checking and ./mach fmt for auto-formatting. As long as the latter makes the former pass, I think it’s fine to add formatting checks.

@atouchet
Copy link
Contributor Author

@atouchet atouchet commented Jul 30, 2020

It looks like the IntelliJ Rust plugin did something similar to this. It might be worth looking at:

intellij-rust/intellij-rust#5518
intellij-rust/intellij-rust#5536

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.