Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve spec compliance of transmit request body #26776

Open
gterzian opened this issue Jun 4, 2020 · 1 comment
Open

Improve spec compliance of transmit request body #26776

gterzian opened this issue Jun 4, 2020 · 1 comment

Comments

@gterzian
Copy link
Member

@gterzian gterzian commented Jun 4, 2020

Spec: https://fetch.spec.whatwg.org/#concept-request-transmit-body

See various TODOs at https://github.com/servo/servo/pull/25873/files#diff-ae0ff1fd98b06dfb13baf427cdffc28aR171

I think this will require storing a Trusted<Request> on the TransmitBodyConnectHandler(in addition to the currently stored Trusted<ReadableStream>), and then queue the various tasks for things like "process end of request body".

Those currently are actually implemented as placeholders, see

fn process_request_body(&mut self) {

However I think the process_request_body and process_request_eof methods on FetchContext and FetchResponseListener might have to be removed in favor of the new mechanism described here where you'd just queue the tasks using the actual Request and the TransmitBodyConnectHandler.

@gterzian
Copy link
Member Author

@gterzian gterzian commented Jun 7, 2020

Actually we probably shouldn't try to queue tasks for this, see the discussion over at whatwg/fetch#536

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.