Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImprove spec compliance of transmit request body #26776
Open
Labels
Comments
|
Actually we probably shouldn't try to queue tasks for this, see the discussion over at whatwg/fetch#536 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Spec: https://fetch.spec.whatwg.org/#concept-request-transmit-body
See various TODOs at https://github.com/servo/servo/pull/25873/files#diff-ae0ff1fd98b06dfb13baf427cdffc28aR171
I think this will require storing a
Trusted<Request>on theTransmitBodyConnectHandler(in addition to the currently storedTrusted<ReadableStream>), and then queue the various tasks for things like "process end of request body".Those currently are actually implemented as placeholders, see
servo/components/script/fetch.rs
Line 203 in 0281ace
However I think the
process_request_bodyandprocess_request_eofmethods onFetchContextandFetchResponseListenermight have to be removed in favor of the new mechanism described here where you'd just queue the tasks using the actualRequestand theTransmitBodyConnectHandler.