Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUWP: Implement a console panel (devtools) #26850
Closed
Comments
bors-servo
added a commit
that referenced
this issue
Jun 17, 2020
[UWP] Basic console panel This PR introduces a Devtools client module to the UWP app. And a basic console panel. There are still bugs and missing features, that I will address in future PRs: - the output is just some text. No colors or formatting. This will be implemented as a [gridview](https://docs.microsoft.com/en-us/dotnet/framework/wpf/controls/gridview-overview) later. - When connecting to the devtools server, we get a prompt asking for permission. I see 2 options: we share the socket between Servo and the UWP app (no idea if that's actually possible) or we keep using the TCP transport and share a token between Servo and the UWP app that would allow to bypass the permission prompt - add a JS input. - show HTTP errors. For now they are just ignored. - There are 3 panels now: console, preference and a random "devtool server" panel that shows the devtools port. We could just print the port number in the console instead. - Servo crashes if we open the devtools too early. This needs investigation. Also, now that we have the foundation of a devtools client in UWP, we should remove the recently introduced preference API and rely on the preference devtools actor instead. Fix #26850
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Now we have a toolbox, we can implement a console.
I think there's 2 different possible approaches:
For a start, we probably don't need to implement a JS REPL. Just listing the logs would be good enough.