Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit the lifetime management of embedder shared objects #26851

Open
paulrouget opened this issue Jun 10, 2020 · 1 comment
Open

Revisit the lifetime management of embedder shared objects #26851

paulrouget opened this issue Jun 10, 2020 · 1 comment

Comments

@paulrouget
Copy link
Contributor

@paulrouget paulrouget commented Jun 10, 2020

#26793 introduced allocated memory that is released on perform_udpate. It's not a great way to handle object lifetime.

We should have a more elegant way to handle the lifetime of objects shared between servo and the embedder.

See

prefs::free_prefs();

@paulrouget
Copy link
Contributor Author

@paulrouget paulrouget commented Jun 29, 2020

To consider: using the devtools protocol instead of using a low level API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.