Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide SharedArrayBuffer #26874

Closed
jdm opened this issue Jun 11, 2020 · 1 comment
Closed

Hide SharedArrayBuffer #26874

jdm opened this issue Jun 11, 2020 · 1 comment
Labels
A-content/bindings
Projects
Hubs support

Comments

@jdm
Copy link
Member

@jdm jdm commented Jun 11, 2020

Right now we expose the SharedArrayBuffer interface through SpiderMonkey, but we have no code that supports passing it to DOM APIs or transferring it between threads. We should probably hide it instead or exposing something that isn't actually useful.
@jdm jdm mentioned this issue Jun 11, 2020
Open
@jdm
Copy link
Member Author

@jdm jdm commented Jun 11, 2020

Having this enabled but not transferable prevents the Hubs room from showing up due to https://github.com/servo/hubs/blob/7e9a9c0d9343704d6e37aafd0311cc501e6775e9/src/systems/physics-system.js#L94-L121.
@jdm jdm added this to To do in Hubs support Jun 11, 2020
@jdm jdm mentioned this issue Jun 11, 2020
Merged
bors-servo added a commit that referenced this issue Jun 11, 2020
@bors-servo
Auto merge of #26875 - servo:jdm-patch-44, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
e6cb255 
Don't pretend we support SharedArrayBuffer.

Fixes #26874.
bors-servo added a commit that referenced this issue Jun 15, 2020
@bors-servo
Auto merge of #26875 - servo:jdm-patch-44, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
6be1e99 
Don't pretend we support SharedArrayBuffer.

Fixes #26874.
bors-servo added a commit that referenced this issue Jun 16, 2020
@bors-servo
Auto merge of #26875 - servo:jdm-patch-44, r=gterzian
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
8ebcefc 
Don't pretend we support SharedArrayBuffer.

Fixes #26874.
bors-servo added a commit that referenced this issue Jun 16, 2020
@bors-servo
Auto merge of #26875 - servo:jdm-patch-44, r=gterzian
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
ac586d5 
Don't pretend we support SharedArrayBuffer.

Fixes #26874.
@atouchet atouchet moved this from To do to Done in Hubs support Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/bindings
Projects
Hubs support
  
Done
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Don't pretend we support SharedArrayBuffer.
1 participant
@jdm
You can’t perform that action at this time.