servo / servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mio 0.7 isn't compatible with UWP #26896

Open

jdm opened this issue Jun 12, 2020 · 3 comments

Labels

A-build A-network B-high-value P-windows

Projects

Member

jdm commented Jun 12, 2020

tokio-rs/mio#912 (comment)

0.7 was released in March, and the afd in question is this code. It relies on the ntapi crate, and given documentation like https://docs.microsoft.com/en-us/windows/win32/devnotes/calling-internal-apis that's linked from https://docs.microsoft.com/en-us/windows/win32/api/winternl/nf-winternl-ntcreatefile, I get very nervous.

jdm added this to To do in UWP port via automation

Member Author

jdm commented Jun 12, 2020

https://docs.microsoft.com/en-us/windows/win32/api/winternl/nf-winternl-rtlntstatustodoserror is definitely not supported in UWP apps (https://github.com/tokio-rs/mio/blob/0ba2ed8bb1e3af999024653d587b9c25f8d4b57c/src/sys/windows/afd.rs#L197).

Member Author

jdm commented Jun 12, 2020

This affects:

mio-extras
mio-uds
tokio
tokio-reactor
tokio-tcp
tokio-udp
tokio-uds
ws

jdm changed the title ~~mio 0.7 might not be compatible with UWP~~ mio 0.7 isn't compatible with UWP

jdm added A-build P-windows A-network B-high-value labels

Member Author

jdm commented Jun 12, 2020

tokio-rs/mio#1314 suggests that it would be worth adding a fake consumer of mio 0.7 to servo and running the WACK to see if anything shows up.

jdm mentioned this issue

Update Tokio and Hyper in net component #26933

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

You can’t perform that action at this time.