Removing a focused element from the tree doesn't reset focus #26900

jdm · 2020-06-12T21:39:52Z

<body>
  <style>div:focus { color: red; }</style>
  <div tabindex=0 id="a" style="background-color: green; width: 100px; height: 100px;"><button onclick="this.parentNode.remove()">remove</button><p>hello</p></div>
<script>
let div = document.querySelector('#a');
div.focus();
div.onkeydown = (e) => { console.log('div down ' + e.key); };
div.onkeyup = (e) => { console.log('div up ' + e.key); };
document.body.onkeydown = function(e) {
  console.log("body down " + e.key);
};
document.body.onkeyup = function(e) {
  console.log("body up " + e.key);
};
</script>

In Firefox, when I press a, then click the remove button and press a again, I see:

div down a
body down a
div up a
body up a
body down a
body up a

Which indicates that the focus was reset such that the div that was removed from the tree is no longer focused.
In Servo, doing the same gives me:

div down a
body down a
div up a
body up a
div down a
div up a

Which indicates that we don't reset the focus when the div is removed from the tree.

jdm · 2020-06-12T21:41:26Z

https://html.spec.whatwg.org/multipage/interaction.html#focus-fixup-rule


        Auto merge of #26902 - jdm:focus-fixes, r=<try>

Focus correctness improvements These changes improve the behaviour of focus in Hubs rooms, and are expected to improve web compat around other dynamic pages that receive keyboard events as well. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #26901 and fix #26900. - [x] There are tests for these changes


        Auto merge of #26902 - jdm:focus-fixes, r=<try>

Focus correctness improvements These changes improve the behaviour of focus in Hubs rooms, and are expected to improve web compat around other dynamic pages that receive keyboard events as well. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #26901 and fix #26900. - [x] There are tests for these changes

jdm added A-content/dom C-has-manual-testcase labels Jun 12, 2020

jdm self-assigned this Jun 12, 2020

jdm mentioned this issue Jun 12, 2020

Focus correctness improvements #26902

Merged

4 of 4 tasks complete

bors-servo closed this in f31d345 Jun 15, 2020

servo / servo

Removing a focused element from the tree doesn't reset focus #26900

Removing a focused element from the tree doesn't reset focus #26900

jdm commented Jun 12, 2020

jdm commented Jun 12, 2020

servo / servo

Join GitHub today

Removing a focused element from the tree doesn't reset focus #26900

Removing a focused element from the tree doesn't reset focus #26900

Comments

jdm commented Jun 12, 2020

jdm commented Jun 12, 2020