Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ToJSVal for webidl dictionaries ignores the parent field #26928

Closed
jdm opened this issue Jun 15, 2020 · 0 comments
Closed

ToJSVal for webidl dictionaries ignores the parent field #26928

jdm opened this issue Jun 15, 2020 · 0 comments
Assignees

Comments

@jdm
Copy link
Member

@jdm jdm commented Jun 15, 2020

dictionary RTCRtpParameters {
  required sequence<RTCRtpHeaderExtensionParameters> headerExtensions;
  required RTCRtcpParameters rtcp;
  required sequence<RTCRtpCodecParameters> codecs;
};

dictionary RTCRtpSendParameters : RTCRtpParameters {
  required DOMString transactionId;
  required sequence<RTCRtpEncodingParameters> encodings;
};

When there is code that calls RTCRtpSender.getParameters() which returns RTCRtpSendParameters, we end up with a JS value that only includes transactionId and encodings, and none of the fields from RTCRtpParameters.

bors-servo added a commit that referenced this issue Jun 15, 2020
Convert parent dictionary values when converting dictionaries to JS

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #26928
- [x] There are tests for these changes OR
@jdm jdm self-assigned this Jun 15, 2020
@jdm jdm added this to To do in Hubs support Jun 15, 2020
bors-servo added a commit that referenced this issue Jun 16, 2020
Convert parent dictionary values when converting dictionaries to JS

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #26928
- [x] There are tests for these changes OR
bors-servo added a commit that referenced this issue Jun 16, 2020
Convert parent dictionary values when converting dictionaries to JS

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #26928
- [x] There are tests for these changes OR
@atouchet atouchet moved this from To do to Done in Hubs support Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Hubs support
  
Done
Linked pull requests

Successfully merging a pull request may close this issue.

1 participant
You can’t perform that action at this time.