Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fire mouseenter/mouseleave events #26958

Closed
jdm opened this issue Jun 17, 2020 · 1 comment
Closed

Fire mouseenter/mouseleave events #26958

jdm opened this issue Jun 17, 2020 · 1 comment
Labels
A-content/dom A-input
Projects
High priority web compat

Comments

@jdm
Copy link
Member

@jdm jdm commented Jun 17, 2020

servo/components/script/dom/document.rs

Line 1449 in 634510c

// TODO: Fire mouseenter here.

servo/components/script/dom/document.rs

Line 1425 in 634510c

// TODO: Fire mouseleave here only if the old target is

This affects the smaller thumbnails on mixer.com.
@jdm
Copy link
Member Author

@jdm jdm commented Jun 17, 2020

https://w3c.github.io/uievents/#events-mouseevent-event-order
https://w3c.github.io/uievents/#event-type-mouseenter
@utsavoza utsavoza mentioned this issue Jul 27, 2020
Merged
3 of 4 tasks complete
bors-servo added a commit that referenced this issue Jul 30, 2020
@bors-servo
Auto merge of #27413 - utsavoza:ugo/issue-26958/26-07-2020, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
f1c835a 
Fire mouseenter and mouseleave events

The PR primarily consists of changes for:
- Fixing the order in which `mousemove` events are fired.
- Firing `mouseenter` and `mouseleave` events.
---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #26958
- [ ] There are tests for these changes
High priority web compat automation moved this from To do to Done Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/dom A-input
Projects
High priority web compat
  
Done
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Fire mouseenter and mouseleave events
1 participant
@jdm
You can’t perform that action at this time.