Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refcell_backtrace doesn't work #26971

Closed
jdm opened this issue Jun 18, 2020 · 0 comments
Closed

refcell_backtrace doesn't work #26971

jdm opened this issue Jun 18, 2020 · 0 comments
Assignees
@jdm
Labels
I-bustage

Comments

@jdm
Copy link
Member

@jdm jdm commented Jun 18, 2020

Our DomRefCell borrow/borrow_mut methods call try_borrow/try_borrow_mut instead of accountable_refcell's borrow/borrow_mut. The backtraces only happen from the borrow/borrow_mut methods.
@jdm jdm added the I-bustage label Jun 18, 2020
@jdm jdm self-assigned this Jun 18, 2020
@jdm jdm mentioned this issue Jun 18, 2020
Merged
bors-servo added a commit that referenced this issue Jun 19, 2020
@bors-servo
Auto merge of #26975 - servo:jdm-patch-44, r=gterzian
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
1c91caf 
Fix refcell_backtrace feature.

This makes the output of a borrow error contain the expected list of conflicting borrows. Fixes #26971.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jdm jdm

Labels
I-bustage
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Fix refcell_backtrace feature.
1 participant
@jdm
You can’t perform that action at this time.