Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Win64 - Unable to close Servo window #26996

Closed
elasmojs opened this issue Jun 19, 2020 · 3 comments
Closed

Win64 - Unable to close Servo window #26996

elasmojs opened this issue Jun 19, 2020 · 3 comments

Comments

@elasmojs
Copy link

@elasmojs elasmojs commented Jun 19, 2020

The close button does not work
@atouchet
Copy link
Contributor

@atouchet atouchet commented Jun 19, 2020

I am not able to reproduce this issue in the latest Servo nightly build on Windows.
@jdm
Copy link
Member

@jdm jdm commented Jun 19, 2020

@elasmojs What website were you browsing at the time?
@gterzian gterzian mentioned this issue Jun 22, 2020
Merged
0 of 5 tasks complete
bors-servo added a commit that referenced this issue Jun 22, 2020
@bors-servo
Auto merge of #27016 - gterzian:fix_closing_window, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
dee9465 
constellation: don't make shutdown depend on having exited all pipelines

<!-- Please describe your changes on the following line: -->

FIX #26685

FIX #26996

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
bors-servo added a commit that referenced this issue Jun 22, 2020
@bors-servo
Auto merge of #27016 - gterzian:fix_closing_window, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
019ac56 
Constellation: don't make shutdown depend on having exited all pipelines

<!-- Please describe your changes on the following line: -->

FIX #26685
FIX #26996
FIX #9672

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@elasmojs
Copy link
Author

@elasmojs elasmojs commented Jun 23, 2020 •
edited

Sorry for the delay, i was just running the windows zip download from servo,org. Here is a link of the recording. I downloaded it again today and the issue persists https://drive.google.com/file/d/1r8bozrp6SNyic1Sg5FVn06pqKb3GAepr/view
@thormme thormme mentioned this issue Jun 26, 2020
Open
bors-servo added a commit that referenced this issue Jun 29, 2020
@bors-servo
Auto merge of #27016 - gterzian:fix_closing_window, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
7332261 
Ensure clean shutdown of JS threads

<!-- Please describe your changes on the following line: -->

FIX #26685
FIX #26996
FIX #9672
FIX #27027

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
bors-servo added a commit that referenced this issue Jun 29, 2020
@bors-servo
Auto merge of #27016 - gterzian:fix_closing_window, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
f4979ca 
Ensure clean shutdown of JS threads

<!-- Please describe your changes on the following line: -->

FIX #26685
FIX #26996
FIX #9672
FIX #27027

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
bors-servo added a commit that referenced this issue Jun 29, 2020
@bors-servo
Auto merge of #27016 - gterzian:fix_closing_window, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
ecae81e 
Ensure clean shutdown of JS threads

<!-- Please describe your changes on the following line: -->

FIX #26685
FIX #26996
FIX #9672
FIX #27027

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
bors-servo added a commit that referenced this issue Jun 30, 2020
@bors-servo
Auto merge of #27016 - gterzian:fix_closing_window, r=jdm,paulrouget
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
9fb1a96 
Ensure clean shutdown of JS threads

<!-- Please describe your changes on the following line: -->

FIX #26685
FIX #26996
FIX #9672
FIX #27027

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Ensure clean shutdown of JS threads
3 participants
@jdm @atouchet @elasmojs
You can’t perform that action at this time.