Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update referrer computation #27030

Closed
jdm opened this issue Jun 22, 2020 · 0 comments
Closed

Update referrer computation #27030

jdm opened this issue Jun 22, 2020 · 0 comments
Labels
A-network I-spec-update

Comments

@jdm
Copy link
Member

@jdm jdm commented Jun 22, 2020

w3c/webappsec-referrer-policy#135 changed the way https://w3c.github.io/webappsec-referrer-policy/#determine-requests-referrer works to compare the origin of the referrer value against the origin of the request's current URL. This corresponds to this code in Servo.

Tests: ./mach test-wpt tests/wpt/web-platform-tests/referrer-policy
@utsavoza utsavoza mentioned this issue Jun 28, 2020
Merged
4 of 4 tasks complete
bors-servo added a commit that referenced this issue Jun 28, 2020
@bors-servo
Auto merge of #27104 - utsavoza:ugo/issue-27030/28-06-2020, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
4fb586e 
Update referrer computation

The PR updates the request's referrer computation in consideration with the recent changes in [w3c/webappsec-referrer-policy#135](w3c/webappsec-referrer-policy#135).

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #27030
- [x] There are tests for these changes
bors-servo added a commit that referenced this issue Jul 2, 2020
@bors-servo
Auto merge of #27104 - utsavoza:ugo/issue-27030/28-06-2020, r=gterzian
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
fc407db 
Update referrer computation

The PR updates the request's referrer computation in consideration with the recent changes in [w3c/webappsec-referrer-policy#135](w3c/webappsec-referrer-policy#135).

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #27030
- [x] There are tests for these changes
bors-servo added a commit that referenced this issue Jul 2, 2020
@bors-servo
Auto merge of #27104 - utsavoza:ugo/issue-27030/28-06-2020, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
b063dab 
Update referrer computation

The PR updates the request's referrer computation in consideration with the recent changes in [w3c/webappsec-referrer-policy#135](w3c/webappsec-referrer-policy#135).

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #27030
- [x] There are tests for these changes
bors-servo added a commit that referenced this issue Jul 3, 2020
@bors-servo
Auto merge of #27104 - utsavoza:ugo/issue-27030/28-06-2020, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
0c09ec9 
Update referrer computation

The PR updates the request's referrer computation in consideration with the recent changes in [w3c/webappsec-referrer-policy#135](w3c/webappsec-referrer-policy#135).

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #27030 and fix #14505
- [x] There are tests for these changes
@bors-servo bors-servo closed this in 8800452 Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-network I-spec-update
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Update referrer computation
1 participant
@jdm
You can’t perform that action at this time.