Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide webdriverCallback and webdriverTimeout methods behind a pref #27033

Open
jdm opened this issue Jun 22, 2020 · 1 comment
Open

Hide webdriverCallback and webdriverTimeout methods behind a pref #27033

jdm opened this issue Jun 22, 2020 · 1 comment

Comments

@jdm
Copy link
Member

@jdm jdm commented Jun 22, 2020

// WebDriver extensions
partial interface Window {
// Shouldn't be public, but just to make things work for now
void webdriverCallback(optional any result);
void webdriverTimeout();
};

This pref can be set for all tests in https://github.com/web-platform-tests/wpt/blob/708893d8180931603d2e6b5e74c45fc2954c4b18/tools/wptrunner/wptrunner/executors/executorservo.py#L43.

@jdm
Copy link
Member Author

@jdm jdm commented Jun 22, 2020

One other subtlety - these will need to be accessible when running with --webdriver, so we should actually enable the pref automatically when the server is started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.