Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing DEFAULT_URL doesn't override locally-stored preference #27046

Closed
jdm opened this issue Jun 23, 2020 · 1 comment
Closed

Changing DEFAULT_URL doesn't override locally-stored preference #27046

jdm opened this issue Jun 23, 2020 · 1 comment
Labels
I-papercut
Projects
UWP port

Comments

@jdm
Copy link
Member

@jdm jdm commented Jun 23, 2020

DEFAULT_URL is only used if there's no shell.homepage preference present in the local preferences in this code. This is really confusing when modifying DEFAULT_URL during development!
@jdm jdm added the I-papercut label Jun 23, 2020
@atouchet atouchet added this to To do in UWP port Jun 24, 2020
@paulrouget
Copy link
Contributor

@paulrouget paulrouget commented Jun 26, 2020

(I have an upcoming fix, will be part of the text events PR)
@paulrouget paulrouget mentioned this issue Jun 29, 2020
Merged
UWP port automation moved this from To do to Done Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
I-papercut
Projects
UWP port
  
Done
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

[UWP] Better default url management
2 participants
@jdm @paulrouget
You can’t perform that action at this time.