Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UWP] support black theme #27058

Closed
paulrouget opened this issue Jun 23, 2020 · 2 comments
Closed

[UWP] support black theme #27058

paulrouget opened this issue Jun 23, 2020 · 2 comments

Comments

@paulrouget
Copy link
Contributor

@paulrouget paulrouget commented Jun 23, 2020

When the Windows app theme is set to dark, UWP controls are black, making icons and color-hardcoded text unreadable.
@paulrouget
Copy link
Contributor Author

@paulrouget paulrouget commented Jun 23, 2020

Also #27059 introduces a hardcoded white background to work around this issue. This will need to be reverted.
@paulrouget
Copy link
Contributor Author

@paulrouget paulrouget commented Jun 26, 2020

Turns out the new UI is dark by default, making this a lot more important. Will look at this soon.
@paulrouget paulrouget mentioned this issue Jun 29, 2020
Merged
bors-servo added a commit that referenced this issue Jun 29, 2020
@bors-servo
Auto merge of #27107 - paulrouget:darktheme, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
eeff410 
UWP: Dark theme support

Removed hard coded colors and replaced icons with builtin icon font.
Fix #27058
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

UWP: Dark theme support
1 participant
@paulrouget
You can’t perform that action at this time.